On Montag, 19. Mai 2025 20:51:49 Mitteleuropäische Sommerzeit Michał Górny 
wrote:
> > --- a/eclass/cmake.eclass
> > +++ b/eclass/cmake.eclass
> > @@ -362,6 +362,18 @@ cmake_src_configure() {
> > 
> >     # Fix xdg collision with sandbox
> >     xdg_environment_reset
> > 
> > +   local file re="cmake_minimum_required *\( *VERSION( .*\.\.\.|
> > )(([[:digit:]]+)\.([[:digit:]]+))" +        local ver cmreq_isold
> > +   while read -d '' -r file ; do
> > +           [[ $(grep -hi "cmake_minimum_required" "$file") =~ $re ]]
> > +           ver="${BASH_REMATCH[2]}"
> 
> So... you're using grep to find a line containing
> "cmake_minimum_required", then applying another regexp to that line?
> This really looks like a case for a single sed call.

I'm glad for any suggestions there.

> 
> > +           echo $file $ver
> 
> Is this leftover debug?

Indeed, thanks.


PR is here:
https://github.com/gentoo/kde/pull/1043


Regards

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to