On Mon, Apr 25, 2005 at 03:04:48AM +0200, Anders Rune Jensen wrote: > Let me first start by saying that committing straight to stable was > clearly a mistake. I can't help wonder why CVS would change patch files > (it probably doesn't know the difference between ordinary files and > patches) This is mostly an assumption here, as I don't know all of the details, but in the past I did run into problems with patches that dealt with the CVS keywords. You'd commit the patch, but doing so would change it, until you commited it with the -kb keyword option.
> or why repoman doesn't catch something like this? CVS changing > files on commit goes against the whole "test before commit" mantra and > I'm probably not the first to have encountered this problem? You aren't the first no, but the solutions to it are limited: - teach developers to use -kb where they should - use an alternative keyword only for the gentoo-x86 module (some of the BSDs do this IIRC) - and turn off the normal keywords. - repoman checks might be very difficult to do, but it should be possible to at least have it do warnings if it finds CVS keywords that might be dangerous. -- Robin Hugh Johnson E-Mail : [EMAIL PROTECTED] Home Page : http://www.orbis-terrarum.net/?l=people.robbat2 ICQ# : 30269588 or 41961639 GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
pgpzxbmtDbieh.pgp
Description: PGP signature
