Jan Kundrát wrote:
Omer Cohen wrote:Actually, I can understand avoiding unnecessary bit flipping. I've done that in databases on occasion. I'll write a SQL statement that checks if there are matching records for an update instead of just executing a statement that makes changes to those matching records. Depending on the likelihood of changes and the number of records to be changed, it was sometimes faster to pre-qualify an update instead of just doing it when it wasn't going to find any matches.
we're talking about one of the biggest OC communities.
<flame> ...and the same community whose members write code like that described in PHP's bug 31261 [1], which seems quite ugly, at least to me. </flame>
My point is that even if developers say their code is stable, it doesn't have to mean it *really* is, altough they're probably correct.
[1] http://bugs.php.net/bug.php?id=31261
That's all the code in that particular bug does, check the value of a bit before turning it off. If it's already off, don't touch it.
--
gentoo-dev@gentoo.org mailing list