commit:     f72da9c5e7b691f145a65839f3e9b0faf8fc67f6
Author:     Andrei Horodniceanu <a.horodniceanu <AT> proton <DOT> me>
AuthorDate: Sat Jul  6 15:15:38 2024 +0000
Commit:     Horodniceanu Andrei <a.horodniceanu <AT> proton <DOT> me>
CommitDate: Sat Jul  6 15:43:41 2024 +0000
URL:        https://gitweb.gentoo.org/repo/user/dlang.git/commit/?id=f72da9c5

dmd-r1.eclass: clarify dependency on stdlib of host compiler

The previous comment, saying that dmd doesn't link the standard lib of
the host compiler, is plain wrong, it always does. The only
particularity is that dmd doesn't seem to need phobos but it does need
druntime. Regardless, a RDEPEND on the host compiler is needed.

Another comment has been added trying to describe the reason why
DLANG_DEPS should be present in DEPEND. My current understanding is that
since the compiler needs to link libraries from SYSROOT (druntime and
phobos) to produce the CHOST dmd executable then those libraries should
be listed in DEPEND. I'm not 100% sure though.

Signed-off-by: Andrei Horodniceanu <a.horodniceanu <AT> proton.me>

 eclass/dmd-r1.eclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/eclass/dmd-r1.eclass b/eclass/dmd-r1.eclass
index e34af81..49ec257 100644
--- a/eclass/dmd-r1.eclass
+++ b/eclass/dmd-r1.eclass
@@ -85,10 +85,10 @@ IDEPEND=">=app-eselect/eselect-dlang-20140709"
 BDEPEND="!selfhost? ( ${DLANG_DEPS} )"
 # We don't need anything in DEPEND, curl is dl-opened
 # so it belongs in RDEPEND.
+#
+# Thinking about this more ${DLANG_DEPS} should probably go in DEPEND. I
+# want, however, to test this before making the fix.
 #DEPEND=
-# Since 2.107.0, dmd links the standard library of the host
-# compiler. Since this eclass is only used by >=dmd-2.107.0-r1 the
-# dependency is added unconditionally.
 RDEPEND="
        ${IDEPEND}
        net-misc/curl[${MULTILIB_USEDEP}]

Reply via email to