commit:     33d5c19549aa60568dbc6c9faf6f426f7193fbd1
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Thu Jun 27 13:26:27 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Jun 27 13:26:27 2024 +0000
URL:        
https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=33d5c195

Don't explicitly assign the empty string in is_subset()

While it is correct to do so, the key may be created without assignment.

Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>

 functions.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/functions.sh b/functions.sh
index afc170a..faf9d64 100644
--- a/functions.sh
+++ b/functions.sh
@@ -235,7 +235,7 @@ is_subset()
                                if (word == ENVIRON["SENTINEL"]) {
                                        break
                                } else {
-                                       set1[word] = ""
+                                       set1[word]
                                }
                        }
                        if (i == 1 || argc - i < 2) {
@@ -243,7 +243,7 @@ is_subset()
                        }
                        for (i++; i < argc; i++) {
                                word = ARGV[i]
-                               set2[word] = ""
+                               set2[word]
                        }
                        for (word in set2) {
                                delete set1[word]

Reply via email to