commit:     4e55535c1e0c49190c257e359a8e3c0c94f18fa4
Author:     Patrick McLean <chutzpah <AT> gentoo <DOT> org>
AuthorDate: Mon Mar 25 21:29:19 2024 +0000
Commit:     Patrick McLean <chutzpah <AT> gentoo <DOT> org>
CommitDate: Mon Mar 25 21:29:46 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e55535c

net-misc/openssh-contrib: Revbump, sync with openssh, remove old

Signed-off-by: Patrick McLean <chutzpah <AT> gentoo.org>

 net-misc/openssh-contrib/Manifest                  |   6 -
 .../openssh-contrib/openssh-contrib-9.5_p1.ebuild  | 505 ---------------------
 ..._p1.ebuild => openssh-contrib-9.7_p1-r1.ebuild} | 129 ++++--
 3 files changed, 80 insertions(+), 560 deletions(-)

diff --git a/net-misc/openssh-contrib/Manifest 
b/net-misc/openssh-contrib/Manifest
index 3ae3fc930cdf..42cd209f7e0e 100644
--- a/net-misc/openssh-contrib/Manifest
+++ b/net-misc/openssh-contrib/Manifest
@@ -1,11 +1,5 @@
 DIST openssh-8_5_P1-hpn-DynWinNoneSwitch-15.2.diff 51428 BLAKE2B 
370b88a7da7f148bf5a4d445f05cf593b486e9df53bba027e2e179726f534b68cf9d94edd6e53024e0b6ff5f20e568727bc9d26c94d0d415603602a80d3ad241
 SHA512 
2d8d887901164b33b2799ff3ec72e86a39ae4a1696e52bcee0872dbae7772fcc534351e6e7f87126ee71b164c74e9091350f14b782f4b242a09f09b4f50d047a
 DIST openssh-8_5_P1-hpn-PeakTput-15.2.diff 2429 BLAKE2B 
849bf3c313719ab7a25c75e82d5dc5ac98365a038b2a66fe58d01eae5b20c7777258b94b5830e799d6909e75c69753cda05a910f3bdab9606fb7d5efa68e05f1
 SHA512 
c4a56fab55fabd1d902d45f235b603708d43f969920e45c9a57e557dccfa9cade2ec61f26d1ace938f6f73e79f17b12f119b5aea9166cbda8e3435b910500914
-DIST openssh-9.3_p2-hpn-15.2-glue.patch.xz 4728 BLAKE2B 
9e3c04a289d0a94b03b871027f4f8476e3981602f5a2d9ac8a8602e08d01248a72c48126ff53a174c8dc95f6bd8608ba75bbc74f5eb427e4ecbe7c7794c7c200
 SHA512 
bb42d001f89b8eb3a5af813d4c526548e13467deeb2811384b473e61c86e6e766aabb9652867953c0f979533ea70111145c424298f11df4faf05e43fb8b1f439
-DIST openssh-9.5_p1-X509-glue-14.3.patch.xz 788 BLAKE2B 
641c9936639a7629f6ae82d56f48b9dd39e58087024fe04259e2be5aef3b484a3f8ba6c91e603dd4f80d03c92490ee85cbaccff1e40e4f7ee1064c4a1ac9f191
 SHA512 
8f9255e3f8a682d7c82125a6064cdd8a80616e4b699a4c101515f15af7185a6b0b98efa246e0ed97a278f377ea616daf2dd98d0dc479c24d1ac3a76c12cd97ec
-DIST openssh-9.5_p1-hpn-15.2-X509-14.3-glue.patch.xz 5132 BLAKE2B 
82a30622e67fab233591f6b30c634f2f8383eda77de163b6139ca9892c0485d8f174901e5e6788f6c911e0859e563ac6a9022e99099507f76a59908770474e78
 SHA512 
697b2ce1b2b0aa1bcf95b76b3bc79de7d8793a3c2975bc3bfb23a64fd3a9133df9fd0831848f9388b21f7f1fd597824b221d45b9380ee26beb60040596386d61
-DIST openssh-9.5p1+x509-14.3.diff.gz 1224337 BLAKE2B 
f695711eeab6b40a8660ac897961068738cb5941c799243888d5a90f56cf4b308803dd88d3d97d7932a72b82ebc269e20c7d142076fb3b03def1245491da0497
 SHA512 
a7798e2a40a81df882911c485fa240584713135df59c6dab720597b6ef60ecfac85ebd595983d7c5ce8625b758eeb777fe1462845976a2674cad339dadc0719a
-DIST openssh-9.5p1.tar.gz 1843001 BLAKE2B 
55dbb0a2792b0046c943a19ca0966660e6e378e77856e94823a1bbbafaa0da94357403765c4c028aebf6543049a0f9bbe0019629be3f92cdadfac1be56def796
 SHA512 
e183fdf7477fd986215b889eea4a945d71385e35305746ccb164e757ecc28166f429c70890a237d8ef4cdcae5132935ba2ecb3b2a658eb73a6afcf6f42277b9c
-DIST openssh-9.5p1.tar.gz.asc 833 BLAKE2B 
abec3d14d9a880008db202be00ed446ccc0a98ce77c16a9e6d6492feac07c8f3284f9cd24f6ee1d904a55f9f23d5cce8a716916975c179a38ef6bde1d36e0acf
 SHA512 
2b6de653420ba02eb99c7e6fba09af3bacfe9c701f3dfc3c94f41a3539c0414954fc5c64cce63c488c5ccd5d4ddb42d3f2184ff7f323342c885c47bf7d426ca1
 DIST openssh-9.6_p1-X509-glue-14.4.2.patch.xz 1516 BLAKE2B 
49f1d100e1b84f051aee599547562bab17b313d097b9b16b7c3ad94fb76e31b04fc101b1824f011507033e9c5744ee0207cb751865576f92501bc442076afe8b
 SHA512 
a09bd2ed9b9d0edfa691c2f99699261c17c9441e188ba870c1f2ceff28817af979a29a7b5c1bbfe9fbeb343241cc00b232099791cc30d665700fcbebdae07139
 DIST openssh-9.6_p1-hpn-15.2-X509-14.4.2-glue.patch.xz 5472 BLAKE2B 
a92ca0746cd48b1580e0a73dcae5d6e141988d3239d09a2f07de376833d14ca2434185b5fdb444fb6821da9ff75ce0c63c86404299e977d3c86050d3a116fc47
 SHA512 
2690f158bf1f5d1512f80c9c8d86006339a461a0bf229e41c62b75d28a9b45cb5392680fbb633415c27c3abfaa1906c170cd1d18679a2be81a1367361fd98afa
 DIST openssh-9.6_p1-hpn-15.2-glue.patch.xz 5028 BLAKE2B 
74970dc9f244eea2e35270c9abe67bdf0f05a3ddb33ffe6ce54056ade3fbec2abe9cb60e92ea889b01be7429dfd754f2986b175cdb014aab721421e1a4952c87
 SHA512 
1edafed18b1fd5d64844a3d121aacbf38dcde2b90adc9b4533f3192f1335365736e9cfd82f7c847980c9b1c1b72ee39470b38d6758b3a8f5ed59796d5005492b

diff --git a/net-misc/openssh-contrib/openssh-contrib-9.5_p1.ebuild 
b/net-misc/openssh-contrib/openssh-contrib-9.5_p1.ebuild
deleted file mode 100644
index ea41cbbeb21c..000000000000
--- a/net-misc/openssh-contrib/openssh-contrib-9.5_p1.ebuild
+++ /dev/null
@@ -1,505 +0,0 @@
-# Copyright 1999-2024 Gentoo Authors
-# Distributed under the terms of the GNU General Public License v2
-
-EAPI=8
-
-inherit user-info flag-o-matic autotools pam systemd toolchain-funcs verify-sig
-
-# Make it more portable between straight releases
-# and _p? releases.
-MY_P=${P/-contrib/}
-PARCH=${MY_P/_}
-
-# PV to USE for HPN patches
-#HPN_PV="${PV^^}"
-HPN_PV="8.5_P1"
-
-HPN_VER="15.2"
-HPN_PATCHES=(
-       openssh-${HPN_PV/./_}-hpn-DynWinNoneSwitch-${HPN_VER}.diff
-       openssh-${HPN_PV/./_}-hpn-PeakTput-${HPN_VER}.diff
-)
-HPN_GLUE_PATCH="openssh-9.3_p2-hpn-${HPN_VER}-glue.patch"
-HPN_PATCH_DIR="HPN-SSH%%20${HPN_VER/./v}%%20${HPN_PV/_P/p}"
-
-X509_VER="14.3"
-X509_PATCH="${PARCH}+x509-${X509_VER}.diff.gz"
-X509_PATCH="${X509_PATCH/p2/p1}"
-X509_GLUE_PATCH="openssh-${PV}-X509-glue-${X509_VER}.patch"
-#X509_HPN_GLUE_PATCH="${MY_P}-hpn-${HPN_VER}-X509-${X509_VER}-glue.patch"
-X509_HPN_GLUE_PATCH="${MY_P}-hpn-${HPN_VER}-X509-${X509_VER%.1}-glue.patch"
-
-DESCRIPTION="Port of OpenBSD's free SSH release with HPN/X509 patches"
-HOMEPAGE="https://www.openssh.com/";
-SRC_URI="mirror://openbsd/OpenSSH/portable/${PARCH}.tar.gz
-       ${HPN_VER:+hpn? (
-               $(printf 
"mirror://sourceforge/project/hpnssh/Patches/${HPN_PATCH_DIR}/%s\n" 
"${HPN_PATCHES[@]}")
-               
https://dev.gentoo.org/~chutzpah/dist/openssh/${HPN_GLUE_PATCH}.xz
-       )}
-       ${X509_VER:+X509? (
-               https://roumenpetrov.info/openssh/x509-${X509_VER}/${X509_PATCH}
-               
https://dev.gentoo.org/~chutzpah/dist/openssh/${X509_GLUE_PATCH}.xz
-               ${HPN_VER:+hpn? ( 
https://dev.gentoo.org/~chutzpah/dist/openssh/${X509_HPN_GLUE_PATCH}.xz )}
-       )}
-       verify-sig? ( mirror://openbsd/OpenSSH/portable/${PARCH}.tar.gz.asc )
-"
-VERIFY_SIG_OPENPGP_KEY_PATH=/usr/share/openpgp-keys/openssh.org.asc
-S="${WORKDIR}/${PARCH}"
-
-LICENSE="BSD GPL-2"
-SLOT="0"
-KEYWORDS="~amd64"
-# Probably want to drop ssl defaulting to on in a future version.
-IUSE="abi_mips_n32 audit debug hpn kerberos ldns libedit livecd pam +pie 
security-key selinux +ssl static test X X509 xmss"
-
-RESTRICT="!test? ( test )"
-
-REQUIRED_USE="
-       hpn? ( ssl )
-       ldns? ( ssl )
-       pie? ( !static )
-       static? ( !kerberos !pam )
-       X509? ( ssl !xmss )
-       xmss? ( ssl  )
-       test? ( ssl )
-"
-
-# tests currently fail with XMSS
-REQUIRED_USE+="test? ( !xmss )"
-
-LIB_DEPEND="
-       audit? ( sys-process/audit[static-libs(+)] )
-       ldns? (
-               net-libs/ldns[static-libs(+)]
-               net-libs/ldns[ecdsa(+),ssl(+)]
-       )
-       libedit? ( dev-libs/libedit:=[static-libs(+)] )
-       security-key? ( >=dev-libs/libfido2-1.5.0:=[static-libs(+)] )
-       selinux? ( >=sys-libs/libselinux-1.28[static-libs(+)] )
-       ssl? ( >=dev-libs/openssl-1.1.1l-r1:0=[static-libs(+)] )
-       virtual/libcrypt:=[static-libs(+)]
-       >=sys-libs/zlib-1.2.3:=[static-libs(+)]
-"
-RDEPEND="
-       !net-misc/openssh
-       acct-group/sshd
-       acct-user/sshd
-       !static? ( ${LIB_DEPEND//\[static-libs(+)]} )
-       pam? ( sys-libs/pam )
-       kerberos? ( virtual/krb5 )
-"
-DEPEND="${RDEPEND}
-       virtual/os-headers
-       kernel_linux? ( !prefix-guest? ( >=sys-kernel/linux-headers-5.1 ) )
-       static? ( ${LIB_DEPEND} )
-"
-RDEPEND="${RDEPEND}
-       pam? ( >=sys-auth/pambase-20081028 )
-       !prefix? ( sys-apps/shadow )
-       X? ( x11-apps/xauth )
-"
-# Weird dep construct for newer gcc-config for bug #872416
-BDEPEND="
-       dev-build/autoconf
-       virtual/pkgconfig
-       || (
-               >=sys-devel/gcc-config-2.6
-               >=sys-devel/clang-toolchain-symlinks-14-r1:14
-               >=sys-devel/clang-toolchain-symlinks-15-r1:15
-               >=sys-devel/clang-toolchain-symlinks-16-r1:*
-       )
-       verify-sig? ( sec-keys/openpgp-keys-openssh )
-"
-
-PATCHES=(
-       "${FILESDIR}/openssh-7.9_p1-include-stdlib.patch"
-       "${FILESDIR}/openssh-8.7_p1-GSSAPI-dns.patch" #165444 integrated into 
gsskex
-       "${FILESDIR}/openssh-6.7_p1-openssl-ignore-status.patch"
-       "${FILESDIR}/openssh-7.5_p1-disable-conch-interop-tests.patch"
-       "${FILESDIR}/openssh-8.0_p1-fix-putty-tests.patch"
-       
"${FILESDIR}/openssh-9.3_p1-deny-shmget-shmat-shmdt-in-preauth-privsep-child.patch"
-       "${FILESDIR}/openssh-8.9_p1-allow-ppoll_time64.patch" #834019
-)
-
-pkg_pretend() {
-       # this sucks, but i'd rather have people unable to `emerge -u openssh`
-       # than not be able to log in to their server any more
-       local missing=()
-       check_feature() { use "${1}" && [[ -z ${!2} ]] && missing+=( "${1}" ); }
-       check_feature hpn HPN_VER
-       check_feature X509 X509_PATCH
-       if [[ ${#missing[@]} -ne 0 ]] ; then
-               eerror "Sorry, but this version does not yet support features"
-               eerror "that you requested: ${missing[*]}"
-               eerror "Please mask ${PF} for now and check back later:"
-               eerror " # echo '=${CATEGORY}/${PF}' >> 
/etc/portage/package.mask"
-               die "Missing requested third party patch."
-       fi
-
-       # Make sure people who are using tcp wrappers are notified of its 
removal. #531156
-       if grep -qs '^ *sshd *:' "${EROOT}"/etc/hosts.{allow,deny} ; then
-               ewarn "Sorry, but openssh no longer supports tcp-wrappers, and 
it seems like"
-               ewarn "you're trying to use it.  Update your 
${EROOT}/etc/hosts.{allow,deny} please."
-       fi
-}
-
-src_unpack() {
-       default
-
-       # We don't have signatures for HPN, X509, so we have to write this 
ourselves
-       use verify-sig && verify-sig_verify_detached 
"${DISTDIR}"/${PARCH}.tar.gz{,.asc}
-}
-
-src_prepare() {
-       sed -i \
-               -e 
"/_PATH_XAUTH/s:/usr/X11R6/bin/xauth:${EPREFIX}/usr/bin/xauth:" \
-               pathnames.h || die
-
-       # don't break .ssh/authorized_keys2 for fun
-       sed -i '/^AuthorizedKeysFile/s:^:#:' sshd_config || die
-
-       eapply -- "${PATCHES[@]}"
-
-       [[ -d ${WORKDIR}/patches ]] && eapply "${WORKDIR}"/patches
-
-       local PATCHSET_VERSION_MACROS=()
-
-       if use X509 ; then
-               pushd "${WORKDIR}" &>/dev/null || die
-               eapply "${WORKDIR}/${X509_GLUE_PATCH}"
-               popd &>/dev/null || die
-
-               eapply "${WORKDIR}"/${X509_PATCH%.*}
-               eapply 
"${FILESDIR}/openssh-9.0_p1-X509-uninitialized-delay.patch"
-
-               # We need to patch package version or any X.509 sshd will 
reject our ssh client
-               # with "userauth_pubkey: could not parse key: string is too 
large [preauth]"
-               # error
-               einfo "Patching package version for X.509 patch set ..."
-               sed -i \
-                       -e "s/^AC_INIT(\[OpenSSH\], 
\[Portable\]/AC_INIT([OpenSSH], [${X509_VER}]/" \
-                       "${S}"/configure.ac || die "Failed to patch package 
version for X.509 patch"
-
-               einfo "Patching version.h to expose X.509 patch set ..."
-               sed -i \
-                       -e "/^#define SSH_PORTABLE.*/a #define SSH_X509         
      \"-PKIXSSH-${X509_VER}\"" \
-                       "${S}"/version.h || die "Failed to sed-in X.509 patch 
version"
-               PATCHSET_VERSION_MACROS+=( 'SSH_X509' )
-       fi
-
-       if use hpn ; then
-               local hpn_patchdir="${T}/openssh-${PV}-hpn${HPN_VER}"
-               mkdir "${hpn_patchdir}" || die
-               cp $(printf -- "${DISTDIR}/%s\n" "${HPN_PATCHES[@]}") 
"${hpn_patchdir}" || die
-               pushd "${hpn_patchdir}" &>/dev/null || die
-               eapply "${WORKDIR}/${HPN_GLUE_PATCH}"
-               use X509 && eapply "${WORKDIR}/${X509_HPN_GLUE_PATCH}"
-               popd &>/dev/null || die
-
-               eapply "${hpn_patchdir}"
-
-               use X509 || eapply 
"${FILESDIR}/openssh-8.6_p1-hpn-version.patch"
-
-               einfo "Patching Makefile.in for HPN patch set ..."
-               sed -i \
-                       -e "/^LIBS=/ s/\$/ -lpthread/" \
-                       "${S}"/Makefile.in || die "Failed to patch Makefile.in"
-
-               einfo "Patching version.h to expose HPN patch set ..."
-               sed -i \
-                       -e "/^#define SSH_PORTABLE/a #define SSH_HPN         
\"-hpn${HPN_VER//./v}\"" \
-                       "${S}"/version.h || die "Failed to sed-in HPN patch 
version"
-               PATCHSET_VERSION_MACROS+=( 'SSH_HPN' )
-
-               if [[ -n "${HPN_DISABLE_MTAES}" ]] ; then
-                       # Before re-enabling, check 
https://bugs.gentoo.org/354113#c6
-                       # and be sure to have tested it.
-                       einfo "Disabling known non-working MT AES cipher per 
default ..."
-
-                       cat > "${T}"/disable_mtaes.conf <<- EOF
-
-                       # HPN's Multi-Threaded AES CTR cipher is currently 
known to be broken
-                       # and therefore disabled per default.
-                       DisableMTAES yes
-                       EOF
-                       sed -i \
-                               -e "/^#HPNDisabled.*/r ${T}/disable_mtaes.conf" 
\
-                               "${S}"/sshd_config || die "Failed to disabled 
MT AES ciphers in sshd_config"
-
-                       sed -i \
-                               -e "/AcceptEnv.*_XXX_TEST$/a 
\\\tDisableMTAES\t\tyes" \
-                               "${S}"/regress/test-exec.sh || die "Failed to 
disable MT AES ciphers in test config"
-               fi
-       fi
-
-       if use X509 || use hpn ; then
-               einfo "Patching sshconnect.c to use SSH_RELEASE in 
send_client_banner() ..."
-               sed -i \
-                       -e "s/PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, 
SSH_VERSION/PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_RELEASE/" \
-                       "${S}"/sshconnect.c || die "Failed to patch 
send_client_banner() to use SSH_RELEASE (sshconnect.c)"
-
-               einfo "Patching sshd.c to use SSH_RELEASE in 
sshd_exchange_identification() ..."
-               sed -i \
-                       -e "s/PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, 
SSH_VERSION/PROTOCOL_MAJOR_2, PROTOCOL_MINOR_2, SSH_RELEASE/" \
-                       "${S}"/sshd.c || die "Failed to patch 
sshd_exchange_identification() to use SSH_RELEASE (sshd.c)"
-
-               einfo "Patching version.h to add our patch sets to SSH_RELEASE 
..."
-               sed -i \
-                       -e "s/^#define SSH_RELEASE.*/#define SSH_RELEASE     
SSH_VERSION SSH_PORTABLE ${PATCHSET_VERSION_MACROS[*]}/" \
-                       "${S}"/version.h || die "Failed to patch SSH_RELEASE 
(version.h)"
-       fi
-
-       eapply_user #473004
-
-       # These tests are currently incompatible with PORTAGE_TMPDIR/sandbox
-       sed -e '/\t\tpercent \\/ d' \
-               -i regress/Makefile || die
-
-       tc-export PKG_CONFIG
-       local sed_args=(
-               -e "s:-lcrypto:$(${PKG_CONFIG} --libs openssl):"
-               # Disable fortify flags ... our gcc does this for us
-               -e 's:-D_FORTIFY_SOURCE=2::'
-       )
-
-       # _XOPEN_SOURCE causes header conflicts on Solaris
-       [[ ${CHOST} == *-solaris* ]] && sed_args+=(
-               -e 's/-D_XOPEN_SOURCE//'
-       )
-       sed -i "${sed_args[@]}" configure{.ac,} || die
-
-       eautoreconf
-}
-
-src_configure() {
-       addwrite /dev/ptmx
-
-       use debug && append-cppflags -DSANDBOX_SECCOMP_FILTER_DEBUG
-       use static && append-ldflags -static
-       use xmss && append-cflags -DWITH_XMSS
-
-       if [[ ${CHOST} == *-solaris* ]] ; then
-               # Solaris' glob.h doesn't have things like GLOB_TILDE, configure
-               # doesn't check for this, so force the replacement to be put in
-               # place
-               append-cppflags -DBROKEN_GLOB
-       fi
-
-       # use replacement, RPF_ECHO_ON doesn't exist here
-       [[ ${CHOST} == *-darwin* ]] && export ac_cv_func_readpassphrase=no
-
-       local myconf=(
-               --with-ldflags="${LDFLAGS}"
-               --disable-strip
-               --with-pid-dir="${EPREFIX}"$(usex kernel_linux '' '/var')/run
-               --sysconfdir="${EPREFIX}"/etc/ssh
-               --libexecdir="${EPREFIX}"/usr/$(get_libdir)/misc
-               --datadir="${EPREFIX}"/usr/share/openssh
-               --with-privsep-path="${EPREFIX}"/var/empty
-               --with-privsep-user=sshd
-               --with-hardening
-               $(use_with audit audit linux)
-               $(use_with kerberos kerberos5 "${EPREFIX}"/usr)
-               $(use_with ldns)
-               $(use_with libedit)
-               $(use_with pam)
-               $(use_with pie)
-               $(use_with selinux)
-               $(usex X509 '' "$(use_with security-key security-key-builtin)")
-               $(use_with ssl openssl)
-               $(use_with ssl ssl-engine)
-       )
-
-       if use elibc_musl; then
-               # musl defines bogus values for UTMP_FILE and WTMP_FILE
-               # https://bugs.gentoo.org/753230
-               myconf+=( --disable-utmp --disable-wtmp )
-       fi
-
-       # Workaround for Clang 15 miscompilation with -fzero-call-used-regs=all
-       # bug #869839 (https://github.com/llvm/llvm-project/issues/57692)
-       tc-is-clang && myconf+=( --without-hardening )
-
-       econf "${myconf[@]}"
-}
-
-src_test() {
-       local tests=( compat-tests )
-       local shell=$(egetshell "${UID}")
-       if [[ ${shell} == */nologin ]] || [[ ${shell} == */false ]] ; then
-               ewarn "Running the full OpenSSH testsuite requires a usable 
shell for the 'portage'"
-               ewarn "user, so we will run a subset only."
-               tests+=( interop-tests )
-       else
-               tests+=( tests )
-       fi
-
-       local -x SUDO= SSH_SK_PROVIDER= TEST_SSH_UNSAFE_PERMISSIONS=1
-       mkdir -p "${HOME}"/.ssh || die
-       emake -j1 "${tests[@]}" </dev/null
-}
-
-# Gentoo tweaks to default config files.
-tweak_ssh_configs() {
-       local locale_vars=(
-               # These are language variables that POSIX defines.
-               # 
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_02
-               LANG LC_ALL LC_COLLATE LC_CTYPE LC_MESSAGES LC_MONETARY 
LC_NUMERIC LC_TIME
-
-               # These are the GNU extensions.
-               # 
https://www.gnu.org/software/autoconf/manual/html_node/Special-Shell-Variables.html
-               LANGUAGE LC_ADDRESS LC_IDENTIFICATION LC_MEASUREMENT LC_NAME 
LC_PAPER LC_TELEPHONE
-       )
-
-       dodir /etc/ssh/ssh_config.d /etc/ssh/sshd_config.d
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_config || die
-       Include "${EPREFIX}/etc/ssh/ssh_config.d/*.conf"
-       EOF
-       cat <<-EOF >> "${ED}"/etc/ssh/sshd_config || die
-       Include "${EPREFIX}/etc/ssh/sshd_config.d/*.conf"
-       EOF
-
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_config.d/9999999gentoo.conf || die
-       # Send locale environment variables (bug #367017)
-       SendEnv ${locale_vars[*]}
-
-       # Send COLORTERM to match TERM (bug #658540)
-       SendEnv COLORTERM
-       EOF
-
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_config.d/9999999gentoo-security.conf 
|| die
-       RevokedHostKeys "${EPREFIX}/etc/ssh/ssh_revoked_hosts"
-       EOF
-
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_revoked_hosts || die
-       # https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
-       ssh-rsa 
AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==
-       EOF
-
-       cat <<-EOF >> "${ED}"/etc/ssh/sshd_config.d/9999999gentoo.conf || die
-       # Allow client to pass locale environment variables (bug #367017)
-       AcceptEnv ${locale_vars[*]}
-
-       # Allow client to pass COLORTERM to match TERM (bug #658540)
-       AcceptEnv COLORTERM
-       EOF
-
-       if use pam ; then
-               cat <<-EOF >> 
"${ED}"/etc/ssh/sshd_config.d/9999999gentoo-pam.conf || die
-               UsePAM yes
-               # This interferes with PAM.
-               PasswordAuthentication no
-               # PAM can do its own handling of MOTD.
-               PrintMotd no
-               PrintLastLog no
-               EOF
-       fi
-
-       if use livecd ; then
-               cat <<-EOF >> 
"${ED}"/etc/ssh/sshd_config.d/9999999gentoo-livecd.conf || die
-               # Allow root login with password on livecds.
-               PermitRootLogin Yes
-               EOF
-       fi
-}
-
-src_install() {
-       emake install-nokeys DESTDIR="${D}"
-       fperms 600 /etc/ssh/sshd_config
-       dobin contrib/ssh-copy-id
-       newinitd "${FILESDIR}"/sshd-r1.initd sshd
-       newconfd "${FILESDIR}"/sshd-r1.confd sshd
-
-       if use pam; then
-               newpamd "${FILESDIR}"/sshd.pam_include.2 sshd
-       fi
-
-       tweak_ssh_configs
-
-       doman contrib/ssh-copy-id.1
-       dodoc CREDITS OVERVIEW README* TODO sshd_config
-       use hpn && dodoc HPN-README
-       use X509 || dodoc ChangeLog
-
-       diropts -m 0700
-       dodir /etc/skel/.ssh
-       rmdir "${ED}"/var/empty || die
-
-       systemd_dounit "${FILESDIR}"/sshd.socket
-       systemd_newunit "${FILESDIR}"/sshd.service.1 sshd.service
-       systemd_newunit "${FILESDIR}"/sshd_at.service.1 '[email protected]'
-}
-
-pkg_preinst() {
-       if ! use ssl && has_version "${CATEGORY}/${PN}[ssl]"; then
-               show_ssl_warning=1
-       fi
-}
-
-pkg_postinst() {
-       local old_ver
-       for old_ver in ${REPLACING_VERSIONS}; do
-               if ver_test "${old_ver}" -lt "5.8_p1"; then
-                       elog "Starting with openssh-5.8p1, the server will 
default to a newer key"
-                       elog "algorithm (ECDSA).  You are encouraged to 
manually update your stored"
-                       elog "keys list as servers update theirs.  See 
ssh-keyscan(1) for more info."
-               fi
-               if ver_test "${old_ver}" -lt "7.0_p1"; then
-                       elog "Starting with openssh-6.7, support for USE=tcpd 
has been dropped by upstream."
-                       elog "Make sure to update any configs that you might 
have.  Note that xinetd might"
-                       elog "be an alternative for you as it supports 
USE=tcpd."
-               fi
-               if ver_test "${old_ver}" -lt "7.1_p1"; then #557388 #555518
-                       elog "Starting with openssh-7.0, support for ssh-dss 
keys were disabled due to their"
-                       elog "weak sizes.  If you rely on these key types, you 
can re-enable the key types by"
-                       elog "adding to your sshd_config or ~/.ssh/config 
files:"
-                       elog "  PubkeyAcceptedKeyTypes=+ssh-dss"
-                       elog "You should however generate new keys using rsa or 
ed25519."
-
-                       elog "Starting with openssh-7.0, the default for 
PermitRootLogin changed from 'yes'"
-                       elog "to 'prohibit-password'.  That means password auth 
for root users no longer works"
-                       elog "out of the box.  If you need this, please update 
your sshd_config explicitly."
-               fi
-               if ver_test "${old_ver}" -lt "7.6_p1"; then
-                       elog "Starting with openssh-7.6p1, openssh upstream has 
removed ssh1 support entirely."
-                       elog "Furthermore, rsa keys with less than 1024 bits 
will be refused."
-               fi
-               if ver_test "${old_ver}" -lt "7.7_p1"; then
-                       elog "Starting with openssh-7.7p1, we no longer patch 
openssh to provide LDAP functionality."
-                       elog "Install sys-auth/ssh-ldap-pubkey and use 
OpenSSH's \"AuthorizedKeysCommand\" option"
-                       elog "if you need to authenticate against LDAP."
-                       elog "See 
https://wiki.gentoo.org/wiki/SSH/LDAP_migration for more details."
-               fi
-               if ver_test "${old_ver}" -lt "8.2_p1"; then
-                       ewarn "After upgrading to openssh-8.2p1 please restart 
sshd, otherwise you"
-                       ewarn "will not be able to establish new sessions. 
Restarting sshd over a ssh"
-                       ewarn "connection is generally safe."
-               fi
-               if ver_test "${old_ver}" -lt "9.2_p1-r1" && systemd_is_booted; 
then
-                       ewarn "From openssh-9.2_p1-r1 the supplied systemd unit 
file defaults to"
-                       ewarn "'Restart=on-failure', which causes the service 
to automatically restart if it"
-                       ewarn "terminates with an unclean exit code or signal. 
This feature is useful for most users,"
-                       ewarn "but it can increase the vulnerability of the 
system in the event of a future exploit."
-                       ewarn "If you have a web-facing setup or are concerned 
about security, it is recommended to"
-                       ewarn "set 'Restart=no' in your sshd unit file."
-               fi
-       done
-
-       if [[ -n ${show_ssl_warning} ]]; then
-               elog "Be aware that by disabling openssl support in openssh, 
the server and clients"
-               elog "no longer support dss/rsa/ecdsa keys.  You will need to 
generate ed25519 keys"
-               elog "and update all clients/servers that utilize them."
-       fi
-
-       if use hpn && [[ -n "${HPN_DISABLE_MTAES}" ]] ; then
-               elog ""
-               elog "HPN's multi-threaded AES CTR cipher is currently known to 
be broken"
-               elog "and therefore disabled at runtime per default."
-               elog "Make sure your sshd_config is up to date and contains"
-               elog ""
-               elog "  DisableMTAES yes"
-               elog ""
-               elog "Otherwise you maybe unable to connect to this sshd using 
any AES CTR cipher."
-               elog ""
-       fi
-}

diff --git a/net-misc/openssh-contrib/openssh-contrib-9.7_p1.ebuild 
b/net-misc/openssh-contrib/openssh-contrib-9.7_p1-r1.ebuild
similarity index 88%
rename from net-misc/openssh-contrib/openssh-contrib-9.7_p1.ebuild
rename to net-misc/openssh-contrib/openssh-contrib-9.7_p1-r1.ebuild
index 5173b0254cbb..bc719634c185 100644
--- a/net-misc/openssh-contrib/openssh-contrib-9.7_p1.ebuild
+++ b/net-misc/openssh-contrib/openssh-contrib-9.7_p1-r1.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit user-info flag-o-matic autotools pam systemd toolchain-funcs verify-sig
+inherit user-info optfeature flag-o-matic autotools pam systemd 
toolchain-funcs verify-sig
 
 # Make it more portable between straight releases
 # and _p? releases.
@@ -59,7 +59,7 @@ REQUIRED_USE="
        ldns? ( ssl )
        pie? ( !static )
        static? ( !kerberos !pam )
-       X509? ( ssl !xmss )
+       X509? ( ssl !xmss !security-key )
        xmss? ( ssl  )
        test? ( ssl )
 "
@@ -74,39 +74,33 @@ LIB_DEPEND="
                net-libs/ldns[ecdsa(+),ssl(+)]
        )
        libedit? ( dev-libs/libedit:=[static-libs(+)] )
-       security-key? ( >=dev-libs/libfido2-1.5.0:=[static-libs(+)] )
        selinux? ( >=sys-libs/libselinux-1.28[static-libs(+)] )
        ssl? ( >=dev-libs/openssl-1.1.1l-r1:0=[static-libs(+)] )
        virtual/libcrypt:=[static-libs(+)]
        >=sys-libs/zlib-1.2.3:=[static-libs(+)]
 "
 RDEPEND="
-       !net-misc/openssh
        acct-group/sshd
        acct-user/sshd
        !static? ( ${LIB_DEPEND//\[static-libs(+)]} )
        pam? ( sys-libs/pam )
        kerberos? ( virtual/krb5 )
 "
-DEPEND="${RDEPEND}
+DEPEND="
+       ${RDEPEND}
        virtual/os-headers
        kernel_linux? ( !prefix-guest? ( >=sys-kernel/linux-headers-5.1 ) )
        static? ( ${LIB_DEPEND} )
 "
-RDEPEND="${RDEPEND}
+RDEPEND="
+       ${RDEPEND}
+       !net-misc/openssh
        pam? ( >=sys-auth/pambase-20081028 )
        !prefix? ( sys-apps/shadow )
-       X? ( x11-apps/xauth )
 "
-# Weird dep construct for newer gcc-config for bug #872416
 BDEPEND="
        dev-build/autoconf
        virtual/pkgconfig
-       || (
-               >=sys-devel/gcc-config-2.6
-               >=sys-devel/clang-toolchain-symlinks-16-r1:*
-               >=sys-devel/clang-toolchain-symlinks-15-r1:15
-       )
        verify-sig? ( sec-keys/openpgp-keys-openssh )
 "
 
@@ -152,9 +146,9 @@ src_prepare() {
        # don't break .ssh/authorized_keys2 for fun
        sed -i '/^AuthorizedKeysFile/s:^:#:' sshd_config || die
 
-       eapply -- "${PATCHES[@]}"
+       [[ -d ${WORKDIR}/patches ]] && PATCHES+=( "${WORKDIR}"/patches )
 
-       [[ -d ${WORKDIR}/patches ]] && eapply "${WORKDIR}"/patches
+       eapply -- "${PATCHES[@]}"
 
        local PATCHSET_VERSION_MACROS=()
 
@@ -291,7 +285,27 @@ src_configure() {
                --datadir="${EPREFIX}"/usr/share/openssh
                --with-privsep-path="${EPREFIX}"/var/empty
                --with-privsep-user=sshd
-               --with-hardening
+               # optional at runtime; guarantee a known path
+               --with-xauth="${EPREFIX}"/usr/bin/xauth
+
+               # --with-hardening adds the following in addition to flags we
+               # already set in our toolchain:
+               # * -ftrapv (which is broken with GCC anyway),
+               # * -ftrivial-auto-var-init=zero (which is nice, but not the 
end of
+               #    the world to not have)
+               # * -fzero-call-used-regs=used (history of miscompilations with
+               #    Clang (bug #872548), ICEs on m68k (bug #920350, gcc 
PR113086,
+               #    gcc PR104820, gcc PR104817, gcc PR110934)).
+               #
+               # Furthermore, OSSH_CHECK_CFLAG_COMPILE does not use 
AC_CACHE_CHECK,
+               # so we cannot just disable -fzero-call-used-regs=used.
+               #
+               # Therefore, just pass --without-hardening, given it doesn't 
negate
+               # our already hardened toolchain defaults, and avoids adding 
flags
+               # which are known-broken in both Clang and GCC and haven't been
+               # proven reliable.
+               --without-hardening
+
                $(use_with audit audit linux)
                $(use_with kerberos kerberos5 "${EPREFIX}"/usr)
                $(use_with ldns)
@@ -306,7 +320,6 @@ src_configure() {
 
        if use elibc_musl; then
                # musl defines bogus values for UTMP_FILE and WTMP_FILE
-               # https://bugs.gentoo.org/753230
                myconf+=( --disable-utmp --disable-wtmp )
        fi
 
@@ -317,24 +330,18 @@ src_configure() {
        econf "${myconf[@]}"
 }
 
-src_test() {
-       local tests=( compat-tests )
-       local shell=$(egetshell "${UID}")
-       if [[ ${shell} == */nologin ]] || [[ ${shell} == */false ]] ; then
-               ewarn "Running the full OpenSSH testsuite requires a usable 
shell for the 'portage'"
-               ewarn "user, so we will run a subset only."
-               tests+=( interop-tests )
-       else
-               tests+=( tests )
-       fi
+tweak_ssh_configs() {
+       cat <<-EOF >> ssh_config.out || die
 
-       local -x SUDO= SSH_SK_PROVIDER= TEST_SSH_UNSAFE_PERMISSIONS=1 
REGRESS_INTEROP_PUTTY=1
-       mkdir -p "${HOME}"/.ssh || die
-       emake -j1 "${tests[@]}" </dev/null
+       Include "${EPREFIX}/etc/ssh/ssh_config.d/*.conf"
+       EOF
+       cat <<-EOF >> sshd_config.out || die
+
+       Include "${EPREFIX}/etc/ssh/sshd_config.d/*.conf"
+       EOF
 }
 
-# Gentoo tweaks to default config files.
-tweak_ssh_configs() {
+create_config_dropins() {
        local locale_vars=(
                # These are language variables that POSIX defines.
                # 
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_02
@@ -345,15 +352,9 @@ tweak_ssh_configs() {
                LANGUAGE LC_ADDRESS LC_IDENTIFICATION LC_MEASUREMENT LC_NAME 
LC_PAPER LC_TELEPHONE
        )
 
-       dodir /etc/ssh/ssh_config.d /etc/ssh/sshd_config.d
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_config || die
-       Include "${EPREFIX}/etc/ssh/ssh_config.d/*.conf"
-       EOF
-       cat <<-EOF >> "${ED}"/etc/ssh/sshd_config || die
-       Include "${EPREFIX}/etc/ssh/sshd_config.d/*.conf"
-       EOF
+       mkdir -p "${WORKDIR}"/etc/ssh/ssh{,d}_config.d || die
 
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_config.d/9999999gentoo.conf || die
+       cat <<-EOF > "${WORKDIR}"/etc/ssh/ssh_config.d/9999999gentoo.conf || die
        # Send locale environment variables (bug #367017)
        SendEnv ${locale_vars[*]}
 
@@ -361,16 +362,16 @@ tweak_ssh_configs() {
        SendEnv COLORTERM
        EOF
 
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_config.d/9999999gentoo-security.conf 
|| die
+       cat <<-EOF > 
"${WORKDIR}"/etc/ssh/ssh_config.d/9999999gentoo-security.conf || die
        RevokedHostKeys "${EPREFIX}/etc/ssh/ssh_revoked_hosts"
        EOF
 
-       cat <<-EOF >> "${ED}"/etc/ssh/ssh_revoked_hosts || die
+       cat <<-EOF > "${WORKDIR}"/etc/ssh/ssh_revoked_hosts || die
        # https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/
        ssh-rsa 
AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==
        EOF
 
-       cat <<-EOF >> "${ED}"/etc/ssh/sshd_config.d/9999999gentoo.conf || die
+       cat <<-EOF > "${WORKDIR}"/etc/ssh/sshd_config.d/9999999gentoo.conf || 
die
        # Allow client to pass locale environment variables (bug #367017)
        AcceptEnv ${locale_vars[*]}
 
@@ -379,7 +380,7 @@ tweak_ssh_configs() {
        EOF
 
        if use pam ; then
-               cat <<-EOF >> 
"${ED}"/etc/ssh/sshd_config.d/9999999gentoo-pam.conf || die
+               cat <<-EOF > 
"${WORKDIR}"/etc/ssh/sshd_config.d/9999999gentoo-pam.conf || die
                UsePAM yes
                # This interferes with PAM.
                PasswordAuthentication no
@@ -390,13 +391,35 @@ tweak_ssh_configs() {
        fi
 
        if use livecd ; then
-               cat <<-EOF >> 
"${ED}"/etc/ssh/sshd_config.d/9999999gentoo-livecd.conf || die
+               cat <<-EOF > 
"${WORKDIR}"/etc/ssh/sshd_config.d/9999999gentoo-livecd.conf || die
                # Allow root login with password on livecds.
                PermitRootLogin Yes
                EOF
        fi
 }
 
+src_compile() {
+       default
+       tweak_ssh_configs
+       create_config_dropins
+}
+
+src_test() {
+       local tests=( compat-tests )
+       local shell=$(egetshell "${UID}")
+       if [[ ${shell} == */nologin ]] || [[ ${shell} == */false ]] ; then
+               ewarn "Running the full OpenSSH testsuite requires a usable 
shell for the 'portage'"
+               ewarn "user, so we will run a subset only."
+               tests+=( interop-tests )
+       else
+               tests+=( tests )
+       fi
+
+       local -x SUDO= SSH_SK_PROVIDER= TEST_SSH_UNSAFE_PERMISSIONS=1 
REGRESS_INTEROP_PUTTY=1
+       mkdir -p "${HOME}"/.ssh || die
+       emake -j1 "${tests[@]}" </dev/null
+}
+
 src_install() {
        emake install-nokeys DESTDIR="${D}"
        fperms 600 /etc/ssh/sshd_config
@@ -408,20 +431,25 @@ src_install() {
                newpamd "${FILESDIR}"/sshd.pam_include.2 sshd
        fi
 
-       tweak_ssh_configs
-
        doman contrib/ssh-copy-id.1
        dodoc CREDITS OVERVIEW README* TODO sshd_config
        use hpn && dodoc HPN-README
        use X509 || dodoc ChangeLog
 
-       diropts -m 0700
-       dodir /etc/skel/.ssh
        rmdir "${ED}"/var/empty || die
 
        systemd_dounit "${FILESDIR}"/sshd.socket
        systemd_newunit "${FILESDIR}"/sshd.service.1 sshd.service
        systemd_newunit "${FILESDIR}"/sshd_at.service.1 '[email protected]'
+
+       # Install dropins with explicit mode, bug 906638, 915840
+       diropts -m0755
+       insopts -m0644
+       insinto /etc/ssh
+       doins -r "${WORKDIR}"/etc/ssh/ssh_config.d
+       diropts -m0700
+       insopts -m0600
+       doins -r "${WORKDIR}"/etc/ssh/sshd_config.d
 }
 
 pkg_preinst() {
@@ -431,6 +459,9 @@ pkg_preinst() {
 }
 
 pkg_postinst() {
+       # bug #139235
+       optfeature "x11 forwarding" x11-apps/xauth
+
        local old_ver
        for old_ver in ${REPLACING_VERSIONS}; do
                if ver_test "${old_ver}" -lt "5.8_p1"; then

Reply via email to