commit:     34cf0a8d2ab1c37cbe725117a8e3edc565b1ef1c
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Jan  7 17:23:29 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Jan  7 17:23:48 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34cf0a8d

dev-util/umockdev: drop -Werror=unused-variable (for Vala)

Exposed by a change in Meson to stop inhibiting Vala warnings, e.g.
```
umockdev-record.p/src/umockdev-pcap.c: At top level:
umockdev-record.p/src/umockdev-pcap.c:101:20: error: 
‘umockdev_ioctl_usb_pcap_handler_properties’ defined but not used 
[-Werror=unused-variable]
  101 | static GParamSpec* 
umockdev_ioctl_usb_pcap_handler_properties[UMOCKDEV_IOCTL_USB_PCAP_HANDLER_NUM_PROPERTIES];
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

See 
https://github.com/mesonbuild/meson/commit/5f659af870011e74299d1455a65c2cd5f5ace51f.

Closes: https://bugs.gentoo.org/919380
Signed-off-by: Sam James <sam <AT> gentoo.org>

 ...ckdev-0.17.18-vala-unused-variable-werror.patch | 22 ++++++++++++++++++++++
 dev-util/umockdev/umockdev-0.17.18.ebuild          |  6 +++++-
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git 
a/dev-util/umockdev/files/umockdev-0.17.18-vala-unused-variable-werror.patch 
b/dev-util/umockdev/files/umockdev-0.17.18-vala-unused-variable-werror.patch
new file mode 100644
index 000000000000..69023f08e5e2
--- /dev/null
+++ b/dev-util/umockdev/files/umockdev-0.17.18-vala-unused-variable-werror.patch
@@ -0,0 +1,22 @@
+https://bugs.gentoo.org/919380
+
+Exposed by a change in Meson to stop inhibiting Vala warnings, e.g.
+```
+umockdev-record.p/src/umockdev-pcap.c: At top level:
+umockdev-record.p/src/umockdev-pcap.c:101:20: error: 
‘umockdev_ioctl_usb_pcap_handler_properties’ defined but not used 
[-Werror=unused-variable]
+  101 | static GParamSpec* 
umockdev_ioctl_usb_pcap_handler_properties[UMOCKDEV_IOCTL_USB_PCAP_HANDLER_NUM_PROPERTIES];
+      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+```
+
+See 
https://github.com/mesonbuild/meson/commit/5f659af870011e74299d1455a65c2cd5f5ace51f.
+--- a/meson.build
++++ b/meson.build
+@@ -21,7 +21,7 @@ add_project_arguments(
+   '-Werror=format-security',
+   '-Werror=format=2',
+   #'-Werror=missing-include-dirs',
+-  '-Werror=unused-variable',
++  #'-Werror=unused-variable',
+   '-Werror=return-type',
+   '-Werror=uninitialized',
+   # experimental: first check this on all Debian architectures

diff --git a/dev-util/umockdev/umockdev-0.17.18.ebuild 
b/dev-util/umockdev/umockdev-0.17.18.ebuild
index d195c94f4c13..b627c3aa9f25 100644
--- a/dev-util/umockdev/umockdev-0.17.18.ebuild
+++ b/dev-util/umockdev/umockdev-0.17.18.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2023 Gentoo Authors
+# Copyright 1999-2024 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=8
@@ -40,6 +40,10 @@ BDEPEND="
        virtual/pkgconfig
 "
 
+PATCHES=(
+       "${FILESDIR}"/${PN}-0.17.18-vala-unused-variable-werror.patch
+)
+
 pkg_setup() {
        use test && python-any-r1_pkg_setup
 }

Reply via email to