commit:     c79fce973fb6d30324caf13ed1ef7881fb9741c9
Author:     Kostadin Shishmanov <kocelfc <AT> tutanota <DOT> com>
AuthorDate: Sat Dec 16 09:24:27 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Dec 16 09:30:54 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c79fce97

app-emulation/virt-manager: allow dev-libs/libisoburn > app-cdr/cdrtools

This commit aims to provide an alternative to the unmaintained cdrtools
which has all sorts of build failures [1] and [2] and needs patching.

Upstream prefers xorrisofs provided by dev-libs/libisoburn over mkisofs
which is provided by app-cdr/cdrtools.[3] I had a look at some other
distros (openSUSE, Fedora and Debian) and they all use xorriso.

The other program that is from cdrtools (isoinfo) has been removed. [4]

[1] https://bugs.gentoo.org/903876
[2] https://bugs.gentoo.org/884771
[3] 
https://github.com/virt-manager/virt-manager/commit/3785abc6f0cb07c02ecc55760547a6f425513915
[4] 
https://github.com/virt-manager/virt-manager/commit/08d1a6a2ddd18f88222f9fdffa3f60f42a40bc67

Bug: https://bugs.gentoo.org/903876
Bug: https://bugs.gentoo.org/884771
Signed-off-by: Kostadin Shishmanov <kocelfc <AT> tutanota.com>
Closes: https://github.com/gentoo/gentoo/pull/34309
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../{virt-manager-9999.ebuild => virt-manager-4.1.0-r1.ebuild}         | 3 ++-
 app-emulation/virt-manager/virt-manager-9999.ebuild                    | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app-emulation/virt-manager/virt-manager-9999.ebuild 
b/app-emulation/virt-manager/virt-manager-4.1.0-r1.ebuild
similarity index 95%
copy from app-emulation/virt-manager/virt-manager-9999.ebuild
copy to app-emulation/virt-manager/virt-manager-4.1.0-r1.ebuild
index d5fd49307e4c..f2ea44f9a428 100644
--- a/app-emulation/virt-manager/virt-manager-9999.ebuild
+++ b/app-emulation/virt-manager/virt-manager-4.1.0-r1.ebuild
@@ -27,7 +27,7 @@ IUSE="gui policykit sasl"
 
 RDEPEND="
        ${PYTHON_DEPS}
-       app-cdr/cdrtools
+       || ( dev-libs/libisoburn app-cdr/cdrtools )
        >=app-emulation/libvirt-glib-1.0.0[introspection]
        >=sys-libs/libosinfo-0.2.10[introspection]
        $(python_gen_cond_dep '
@@ -102,4 +102,5 @@ pkg_postinst() {
 
        optfeature "SSH_ASKPASS program implementation" 
lxqt-base/lxqt-openssh-askpass net-misc/ssh-askpass-fullscreen 
net-misc/x11-ssh-askpass
        optfeature "QEMU host support" app-emulation/qemu[usbredir,spice]
+       optfeature "virt-install --location ISO support" dev-libs/libisoburn
 }

diff --git a/app-emulation/virt-manager/virt-manager-9999.ebuild 
b/app-emulation/virt-manager/virt-manager-9999.ebuild
index d5fd49307e4c..a7e83d3bf708 100644
--- a/app-emulation/virt-manager/virt-manager-9999.ebuild
+++ b/app-emulation/virt-manager/virt-manager-9999.ebuild
@@ -27,7 +27,7 @@ IUSE="gui policykit sasl"
 
 RDEPEND="
        ${PYTHON_DEPS}
-       app-cdr/cdrtools
+       || ( dev-libs/libisoburn app-cdr/cdrtools )
        >=app-emulation/libvirt-glib-1.0.0[introspection]
        >=sys-libs/libosinfo-0.2.10[introspection]
        $(python_gen_cond_dep '

Reply via email to