commit:     6cc272a063014b32500e87c00f8d09f5a0eecce3
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Fri Oct  6 00:00:52 2023 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Wed Oct 18 04:26:01 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6cc272a0

app-text/calibre: trivial refactor of skippable tests

It is easier to add to as an array. Also add comment to note down that I
don't know why a couple of tests are being skipped.

Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 app-text/calibre/calibre-5.44.0-r2.ebuild | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/app-text/calibre/calibre-5.44.0-r2.ebuild 
b/app-text/calibre/calibre-5.44.0-r2.ebuild
index 833cd49b4dc6..b90a58692d78 100644
--- a/app-text/calibre/calibre-5.44.0-r2.ebuild
+++ b/app-text/calibre/calibre-5.44.0-r2.ebuild
@@ -198,16 +198,20 @@ src_compile() {
 
 src_test() {
        # Skipped tests:
-       # - 7z (unpackaged Python dependency: py7zr)
-       # - test_unrar (unpackaged Python dependency: unrardll)
-       #
        # Note that we currently have a hack to skip one part of test_qt!
        # See PATCHES for more.
-       ${PYTHON} setup.py test \
-                       --exclude-test-name 7z \
-                       --exclude-test-name test_mem_leaks \
-                       --exclude-test-name test_searching \
-                       --exclude-test-name test_unrar || die
+       local _test_excludes=(
+               # unpackaged Python dependency: py7zr
+               7z
+               # unpackaged Python dependency: unrardll
+               test_unrar
+
+               # undocumented reasons
+               test_mem_leaks
+               test_searching
+       )
+
+       ${PYTHON} setup.py test "${_test_excludes[@]/#/--exclude-test-name=}" 
|| die
 }
 
 src_install() {

Reply via email to