commit: cf33741bdf6abad9af948cffcbb7e185ce737180
Author: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Sat Sep 2 06:02:07 2023 +0000
Commit: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Tue Sep 5 13:01:11 2023 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf33741b
qt6-build.eclass: move filter-lto to src_prepare
While it feels more right in configure (along with match_cpu_flags),
sometime need to check/use compiler flags in src_configure and it is
troublesome if not modified until call the eclass' src_configure.
Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>
eclass/qt6-build.eclass | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/eclass/qt6-build.eclass b/eclass/qt6-build.eclass
index 8db83524d5e3..187427dd04da 100644
--- a/eclass/qt6-build.eclass
+++ b/eclass/qt6-build.eclass
@@ -109,6 +109,17 @@ qt6-build_src_prepare() {
_qt6-build_prepare_env
_qt6-build_match_cpu_flags
+
+ # LTO cause test failures in several components (e.g. qtcharts,
+ # multimedia, scxml, wayland, webchannel, ...).
+ #
+ # Exact extent/causes unknown, but for some related-sounding bugs:
+ # https://bugreports.qt.io/browse/QTBUG-112332
+ # https://bugreports.qt.io/browse/QTBUG-115731
+ #
+ # Does not manifest itself with clang:16 (did with gcc-13.2.0), but
+ # still assumed to be generally unsafe either way in current state.
+ filter-lto
}
# @FUNCTION: qt6-build_src_configure
@@ -136,17 +147,6 @@ qt6-build_src_configure() {
-DQT_USE_DEFAULT_CMAKE_OPTIMIZATION_FLAGS=ON
)
- # LTO cause test failures in several components (e.g. qtcharts,
- # multimedia, scxml, wayland, webchannel, ...).
- #
- # Exact extent/causes unknown, but for some related-sounding bugs:
- # https://bugreports.qt.io/browse/QTBUG-112332
- # https://bugreports.qt.io/browse/QTBUG-115731
- #
- # Does not manifest itself with clang:16 (did with gcc-13.2.0), but
- # still assumed to be generally unsafe either way in current state.
- filter-lto
-
cmake_src_configure
}
