commit: 145cf9016a2b5a1ed7bba08c70ff79d6954837a0
Author: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Thu Jun 1 00:42:14 2023 +0000
Commit: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Thu Jun 1 00:48:53 2023 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=145cf901
linux-mod-r1.eclass: drop <name> volatile make guessed target
<name> without .ko can easily trigger implicit build rules,
as far as I can tell no ebuild has needed ever needed
TARGETS="name" including those already migrated (some *do*
need "name.ko"), so should be safe to just drop it.
Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>
eclass/linux-mod-r1.eclass | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass
index 30395c1496f5..233610a7a587 100644
--- a/eclass/linux-mod-r1.eclass
+++ b/eclass/linux-mod-r1.eclass
@@ -349,8 +349,8 @@ linux-mod-r1_pkg_setup() {
# > make-target: Almost always unneeded but, if defaults are not right,
# then can specify the Makefile's target(s) to build the module/extras.
# Multiple targets can be used with spaces, e.g. :"first second".
-# -> Default: specially tries modules, module, <name>.ko, <name>,
-# default, all, empty target, and runs the first found usable
+# -> Default: specially tries modules, module, <name>.ko, default,
+# all, empty target, and runs the first found usable
#
# Missing elements results in defaults being used, e.g. this is valid:
# modlist=( name1 name2=:source name3=install::build )
@@ -406,7 +406,7 @@ linux-mod-r1_src_compile() {
if [[ -z ${mod[3]} ]]; then
# guess between commonly used targets if none given,
fallback to
# an empty target without trying to see the error output
- for target in module{s,} "${name}"{.ko,} default all; do
+ for target in module{s,} "${name}".ko default all; do
nonfatal emake "${emakeargs[@]}" -q "${target}"
&>/dev/null
if [[ ${?} -eq 1 ]]; then
mod[3]=${target}
