commit:     23026087ef73829b1554ce1a8ac35e3652df870f
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri May  5 07:28:40 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri May  5 07:29:40 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23026087

net-vpn/tor: add commentary wrt --disable-zstd-advanced-apis

Bug: https://bugs.gentoo.org/727406
Bug: https://bugs.gentoo.org/905708
Signed-off-by: Sam James <sam <AT> gentoo.org>

 net-vpn/tor/tor-0.4.7.13-r1.ebuild | 8 ++++++++
 net-vpn/tor/tor-9999.ebuild        | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/net-vpn/tor/tor-0.4.7.13-r1.ebuild 
b/net-vpn/tor/tor-0.4.7.13-r1.ebuild
index c0799853f0f6..2efaf6e602af 100644
--- a/net-vpn/tor/tor-0.4.7.13-r1.ebuild
+++ b/net-vpn/tor/tor-0.4.7.13-r1.ebuild
@@ -106,7 +106,15 @@ src_configure() {
                --disable-module-dirauth
                --enable-pic
                --disable-restart-debugging
+
+               # This option is enabled by default upstream w/ zstd, 
surprisingly.
+               # zstd upstream says this shouldn't be relied upon and it may
+               # break API & ABI at any point, so Tor tries to fake 
static-linking
+               # to make it work, but then requires a rebuild on any new zstd 
version
+               # even when its standard ABI hasn't changed.
+               # See bug #727406 and bug #905708.
                --disable-zstd-advanced-apis
+
                $(use_enable man asciidoc)
                $(use_enable man manpage)
                $(use_enable lzma)

diff --git a/net-vpn/tor/tor-9999.ebuild b/net-vpn/tor/tor-9999.ebuild
index 9ea49a861452..0e36a664f706 100644
--- a/net-vpn/tor/tor-9999.ebuild
+++ b/net-vpn/tor/tor-9999.ebuild
@@ -119,7 +119,15 @@ src_configure() {
                --disable-module-dirauth
                --enable-pic
                --disable-restart-debugging
+
+               # This option is enabled by default upstream w/ zstd, 
surprisingly.
+               # zstd upstream says this shouldn't be relied upon and it may
+               # break API & ABI at any point, so Tor tries to fake 
static-linking
+               # to make it work, but then requires a rebuild on any new zstd 
version
+               # even when its standard ABI hasn't changed.
+               # See bug #727406 and bug #905708.
                --disable-zstd-advanced-apis
+
                $(use_enable man asciidoc)
                $(use_enable man manpage)
                $(use_enable lzma)

Reply via email to