commit:     f0a6155b2ec6f737d7258cf9baa75a9aeca8f1de
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Mon Feb  6 06:27:47 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Feb  6 13:46:56 2023 +0000
URL:        
https://gitweb.gentoo.org/proj/gentoo-functions.git/commit/?id=f0a6155b

Don't unsuccessfully attempt to background the defunct rc_splash utility

The media-gfx/splashutils package was dropped in November 2018, and was
probably not even usable for some time before that. Currently, every
time the _eend() function handles an exit status code other than 0, it
tries to run rc_splash in the background with no possible chance of
success. It also incurs an utterly useless syscall, in order to
determine whether /dev/null is a character device. Cease and desist.

Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 functions.sh | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/functions.sh b/functions.sh
index ae7d151..0a5d38e 100644
--- a/functions.sh
+++ b/functions.sh
@@ -235,11 +235,6 @@ _eend()
                yesno "${EINFO_QUIET}" && return 0
                msg="${BRACKET}[ ${GOOD}ok${BRACKET} ]${NORMAL}"
        else
-               if [ -c /dev/null ] ; then
-                       rc_splash "stop" >/dev/null 2>&1 &
-               else
-                       rc_splash "stop" &
-               fi
                if [ -n "$*" ] ; then
                        ${efunc} "$*"
                fi

Reply via email to