commit:     68a42036991752020ece9bc09cb06f82e7440a0a
Author:     Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Sun Dec  4 04:41:09 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Dec  6 09:11:27 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68a42036

net-vpn/networkmanager-strongswan: Apply patsub_replacement defences

Per bug #881383, string replacing forms of parameter expansion must take care
to quote - or appropriately escape - any nested parameter expansions, assuming
that their values are intended to be taken literally (as is almost invariably
the case). This has long been the case, but the introduction of the new
patsub_replacement option in bash >=5.2 has brought the issue to the fore.

In the case of the net-vpn/networkmanager-strongswan package, the improper
quoting is not yet causing any issues. Still, it is better to write the code
properly to begin with, especially considering the demonstrative value of
robust code.

Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Bug: https://bugs.gentoo.org/881383
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../networkmanager-strongswan/networkmanager-strongswan-1.6.0.ebuild    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/net-vpn/networkmanager-strongswan/networkmanager-strongswan-1.6.0.ebuild 
b/net-vpn/networkmanager-strongswan/networkmanager-strongswan-1.6.0.ebuild
index 86e540e050db..72f1817ebf23 100644
--- a/net-vpn/networkmanager-strongswan/networkmanager-strongswan-1.6.0.ebuild
+++ b/net-vpn/networkmanager-strongswan/networkmanager-strongswan-1.6.0.ebuild
@@ -6,7 +6,7 @@ EAPI=8
 inherit autotools
 
 MY_PN="NetworkManager"
-MY_P="${P/networkmanager/${MY_PN}}"
+MY_P="${P/networkmanager/"${MY_PN}"}"
 
 DESCRIPTION="NetworkManager StrongSwan plugin"
 HOMEPAGE="https://www.strongswan.org/";

Reply via email to