commit: 51148f5256d4c1d10138f967a884a6f7aa58fdca Author: Michael Orlitzky <mjo <AT> gentoo <DOT> org> AuthorDate: Wed Nov 30 23:20:19 2022 +0000 Commit: Michael Orlitzky <mjo <AT> gentoo <DOT> org> CommitDate: Wed Nov 30 23:27:07 2022 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51148f52
net-analyzer/nagios-plugins: use ping/ping6 from $PATH in v2.4.2. We pass explicit ping/ping6 commands to the nagios-plugins ./configure script to prevent it from running those commands during the build. However, instead of grabbing their paths from $PATH, we have (until now) hard-coded them to /bin/ping and /bin/ping6. This has now bitten us with net-misc/iputils-20221126. This commit uses $(command -v ...) to get the right absolute paths. Thanks to Daniel Pouzzner for reporting the problem and suggesting the fix. Closes: https://bugs.gentoo.org/883765 Signed-off-by: Michael Orlitzky <mjo <AT> gentoo.org> net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild b/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild index 7b20af18afa6..8fe32f3ad69a 100644 --- a/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild +++ b/net-analyzer/nagios-plugins/nagios-plugins-2.4.2.ebuild @@ -83,11 +83,12 @@ src_configure() { fi # The autodetection for these two commands can hang if localhost is - # down or ICMP traffic is filtered. Bug #468296. - myconf+=( --with-ping-command="/bin/ping -n -U -w %d -c %d %s" ) + # down or ICMP traffic is filtered (bug #468296). But also the path + # likes to move around on us (bug #883765). + myconf+=( --with-ping-command="$(command -v ping) -n -U -w %d -c %d %s" ) if use ipv6; then - myconf+=( --with-ping6-command="/bin/ping6 -n -U -w %d -c %d %s" ) + myconf+=( --with-ping6-command="$(command -v ping6) -n -U -w %d -c %d %s" ) fi econf \
