commit:     0fdbbbdb5a80e331adf701f2b2c1f096695447c4
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Sun Nov 20 23:32:08 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Nov 20 23:33:43 2022 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=0fdbbbdb

install-qa-check.d/90gcc-warnings: don't make implicit func decls fatal for now

We need to do this at some point (as Clang 16 and GCC 14 are doing it, and
they indicate runtime problems anyway), but there's too much breakage for now.

We did find some extra bugs though. The main issue is too much high-profile
stuff breaks rather than the total number of bugs, wrt Portage behaviour
changing being suitable or not.

Bug: https://bugs.gentoo.org/870412
Signed-off-by: Sam James <sam <AT> gentoo.org>

 NEWS                                  | 4 ++++
 bin/install-qa-check.d/90gcc-warnings | 7 ++++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index 7b97f2a86..28f482350 100644
--- a/NEWS
+++ b/NEWS
@@ -16,6 +16,10 @@ Bug fixes:
 
 * Fix DeprecationWarning in sets.
 
+* install-qa-check.d: 90gcc-warnigns: Disable -Wimplicit-function-declaration 
being
+  fatal for now. The number of failures in bug #870412 is too large for the 
time
+  being.
+
 portage-3.0.39 (2022-11-20)
 --------------
 

diff --git a/bin/install-qa-check.d/90gcc-warnings 
b/bin/install-qa-check.d/90gcc-warnings
index 7a27b5aaa..431cc7639 100644
--- a/bin/install-qa-check.d/90gcc-warnings
+++ b/bin/install-qa-check.d/90gcc-warnings
@@ -153,9 +153,10 @@ gcc_warn_check() {
                        #       always_overflow=yes
                        #fi
 
-                       if [[ ${f} == *'[-Wimplicit-function-declaration]'* ]] 
; then
-                               implicit_func_decl=yes
-                       fi
+                       # Disabled for now because too many failures. bug 
#870412.
+                       #if [[ ${f} == *'[-Wimplicit-function-declaration]'* ]] 
; then
+                       #       implicit_func_decl=yes
+                       #fi
 
                        if [[ ${always_overflow} = yes || ${implicit_func_decl} 
= yes ]] ; then
                                eerror

Reply via email to