commit:     d312126538f24aed777addc15e0a572f9e670f58
Author:     Andrew Udvare <audvare <AT> gmail <DOT> com>
AuthorDate: Mon Jun 20 02:59:41 2022 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Mon Jun 20 03:02:20 2022 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d3121265

sys-apps/dbus: minor shellcheck fixes

* [x]  Run shellcheck
* [x]  Use `$(...)` syntax instead of backticks
* [x]  Quote eval arguments

Bug: https://bugs.gentoo.org/845141
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Andrew Udvare <audvare <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/25988
Signed-off-by: Sam James <sam <AT> gentoo.org>

 sys-apps/dbus/{dbus-1.14.0-r3.ebuild => dbus-1.14.0-r4.ebuild} | 0
 sys-apps/dbus/files/80-dbus-r1                                 | 4 ++--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys-apps/dbus/dbus-1.14.0-r3.ebuild 
b/sys-apps/dbus/dbus-1.14.0-r4.ebuild
similarity index 100%
rename from sys-apps/dbus/dbus-1.14.0-r3.ebuild
rename to sys-apps/dbus/dbus-1.14.0-r4.ebuild

diff --git a/sys-apps/dbus/files/80-dbus-r1 b/sys-apps/dbus/files/80-dbus-r1
index edef88a3c30c..3499a6a12eca 100644
--- a/sys-apps/dbus/files/80-dbus-r1
+++ b/sys-apps/dbus/files/80-dbus-r1
@@ -2,12 +2,12 @@
 
 # launches a session dbus instance
 
-dbuslaunch="`command -v dbus-launch 2>/dev/null`"
+dbuslaunch=$(command -v dbus-launch 2>/dev/null)
 if [ -n "$dbuslaunch" ] && [ -x "$dbuslaunch" ] && [ -z 
"$DBUS_SESSION_BUS_ADDRESS" ]; then
   if [ -n "$command" ]; then
     command="$dbuslaunch --exit-with-session $command"
   else
-    eval `$dbuslaunch --sh-syntax --exit-with-session`
+    eval "$($dbuslaunch --sh-syntax --exit-with-session)"
   fi
 fi
 

Reply via email to