commit: 618db8bdc8f82972815a9f717a4be0df71f0e52c Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> AuthorDate: Sat Feb 12 18:04:10 2022 +0000 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> CommitDate: Sat Feb 12 18:04:10 2022 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=618db8bd
qlop: fix Coverity condition always true CID 248869 atom->pfx_op cannot be 2 values at the same time so, pfx_op != X || pfx_op != Y has to be always true fix it to turn into and condition, which makes more sense in the code flow Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> qlop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qlop.c b/qlop.c index afa4c19..addb4b3 100644 --- a/qlop.c +++ b/qlop.c @@ -1,5 +1,5 @@ /* - * Copyright 2005-2021 Gentoo Foundation + * Copyright 2005-2022 Gentoo Foundation * Distributed under the terms of the GNU General Public License v2 * * Copyright 2005-2010 Ned Ludd - <[email protected]> @@ -1259,7 +1259,7 @@ static int do_emerge_log( continue; } case NEWER: - if (atom->pfx_op != ATOM_OP_NEWER || + if (atom->pfx_op != ATOM_OP_NEWER && atom->pfx_op != ATOM_OP_NEWER_EQUAL) continue; /* fall through */
