commit: c7fe1066a8fcd35f965de4ea16c9cd1001830642 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Fri Aug 13 01:37:15 2021 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Mon Aug 16 02:12:06 2021 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c7fe1066
metadata/install-qa-check.d: add 60tmpfiles-path QA check This adds two tmpfiles related QA checks: 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which is a forbidden (user-configuration) location; 2) Check whether packages inherit tmpfiles.eclass if they're installing files to /usr/lib/tmpfiles.d. (This helps to catch packages not calling tmpfiles_process in pkg_postinst). Signed-off-by: Sam James <sam <AT> gentoo.org> metadata/install-qa-check.d/60tmpfiles-paths | 37 ++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/metadata/install-qa-check.d/60tmpfiles-paths b/metadata/install-qa-check.d/60tmpfiles-paths new file mode 100644 index 00000000000..ed0bdbff8cd --- /dev/null +++ b/metadata/install-qa-check.d/60tmpfiles-paths @@ -0,0 +1,37 @@ +# Copyright 2021 Gentoo Authors +# Distributed under the terms of the GNU General Public License v2 + +# QA check: ensure that packages installing tmpfiles configuration inherit the eclass +# Maintainer: Sam James <[email protected]> + +# Implements two checks: +# 1) Installation to /etc/tmpfiles.d (which is a user-customization location); +# 2) Installation of any tmpfiles to /usr/lib/tmpfiles.d without inheriting the eclass +# (needed for tmpfiles_process in pkg_postinst) +tmpfiles_check() { + # Check 1 + # Scan image for files in /etc/tmpfiles.d which is a forbidden location + if [[ -d "${ED}"/etc/tmpfiles.d/ ]] ; then + eqawarn "QA Notice: files installed to /etc/tmpfiles.d" + eqawarn "tmpfiles configuration files must be installed by ebuilds /usr/lib/tmpfiles.d!" + fi + + # Check 2 + # We're now going to check for whether we install files to /usr/lib/tmpfiles.d without + # inheriting the eclass (weak catch for ebuilds not calling tmpfiles_process in pkg_postinst) + + # No need to carry on if we're inheriting the eclass + if has tmpfiles ${INHERITED} ; then + return + fi + + if [[ -d "${ED}"/usr/lib/tmpfiles.d/ ]] ; then + eqawarn "QA Notice: package is installing tmpfiles without inheriting tmpfiles.eclass!" + eqawarn "Packages must inherit tmpfiles.eclass then call tmpfiles_process in pkg_postinst." + fi +} + +tmpfiles_check +: # guarantee successful exit + +# vim:ft=sh
