commit: 1a1d605e9d4d2d23b221ac499b884f0bc59528a9 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Sat Jul 31 00:32:44 2021 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sat Jul 31 00:32:53 2021 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a1d605e
net-misc/icecast: [QA] unconditionally install logrotate files QA policy [0] says that we don't conditionalise installation of small files. It's a wasteful rebuild and inconsistent across packages for when users desire completions to be available. [0] https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0301 Signed-off-by: Sam James <sam <AT> gentoo.org> net-misc/icecast/icecast-2.4.4-r1.ebuild | 14 ++++++-------- net-misc/icecast/metadata.xml | 1 - 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/net-misc/icecast/icecast-2.4.4-r1.ebuild b/net-misc/icecast/icecast-2.4.4-r1.ebuild index 08a3afff7a2..3e9a5650a56 100644 --- a/net-misc/icecast/icecast-2.4.4-r1.ebuild +++ b/net-misc/icecast/icecast-2.4.4-r1.ebuild @@ -12,7 +12,7 @@ SRC_URI="https://downloads.xiph.org/releases/icecast/${P}.tar.gz"; LICENSE="GPL-2" SLOT="0" KEYWORDS="amd64 ppc ppc64 x86" -IUSE="kate logrotate +speex +ssl +theora +yp" +IUSE="kate +speex +ssl +theora +yp" #Although there is a --with-ogg and --with-orbis configure option, they're #only useful for specifying paths, not for disabling. @@ -24,7 +24,6 @@ DEPEND=" media-libs/libogg media-libs/libvorbis kate? ( media-libs/libkate ) - logrotate? ( app-admin/logrotate ) speex? ( media-libs/speex ) ssl? ( dev-libs/openssl:0= @@ -73,12 +72,11 @@ src_install() { doins "${FILESDIR}"/icecast.xml fperms 600 /etc/icecast2/icecast.xml - if use logrotate; then - dodir /etc/logrotate.d - insopts -m0644 - insinto /etc/logrotate.d - newins "${FILESDIR}"/${PN}.logrotate ${PN} - fi + dodir /etc/logrotate.d + insopts -m0644 + insinto /etc/logrotate.d + newins "${FILESDIR}"/${PN}.logrotate ${PN} + diropts -m0764 -o icecast -g icecast dodir /var/log/icecast keepdir /var/log/icecast diff --git a/net-misc/icecast/metadata.xml b/net-misc/icecast/metadata.xml index fffe116b2fd..d16442c35c9 100644 --- a/net-misc/icecast/metadata.xml +++ b/net-misc/icecast/metadata.xml @@ -7,7 +7,6 @@ </maintainer> <use> <flag name="kate">Add karaoke and text encapsulation support for Ogg files</flag> - <flag name="logrotate">Install support files for <pkg>app-admin/logrotate</pkg>?</flag> <flag name="yp">Build support for yp public directory listings</flag> </use> </pkgmetadata>
