commit:     2b304d8ee40c38023411a3ea184c29ad5a1f8070
Author:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
AuthorDate: Tue May  4 07:53:23 2021 +0000
Commit:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
CommitDate: Tue May  4 07:53:23 2021 +0000
URL:        https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=2b304d8e

Makefile.am: don't mangle final binary with sed

In bug #774861 pash found out that /bin/sh -> busybox produces
invalid `sandbox` binary. It happens because `busybox sed` does
not implement hex escape insertions, like:

    $ printf "a" | gnu-sed 's/a/\x00/' | hexdump -C
    00000000  00                                                |.|
    $ printf "a" | busybox sed 's/a/\x00/' | hexdump -C
    00000000  78 30 30                                          |x00|

The change exposes `__SANDBOX_TESTING` variable to external users.

Reported-by: pash
Bug: https://bugs.gentoo.org/774861
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>

 Makefile.am | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 5541f67..b0ea65f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -47,12 +47,3 @@ dist-hook:
                        touch "$(distdir)/ChangeLog" ; \
                fi ; \
        fi
-
-install-exec-hook:
-       set -e ; \
-       for f in $(bindir)/sandbox $(libdir)/libsandbox.so ; do \
-               sed -i.tmp \
-                       
's:__SANDBOX_TESTING:\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00:'
 \
-                       $(DESTDIR)$$f ; \
-               rm -f $(DESTDIR)$$f.tmp ; \
-       done

Reply via email to