commit: f72795c60b475cc36501ed03b7b3a03c38bcf851 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Sun Mar 21 02:50:27 2021 +0000 Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org> CommitDate: Tue Mar 30 18:14:56 2021 +0000 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=f72795c6
ebuild-writing/common-mistakes: mention "the compiler", not only GCC Signed-off-by: Sam James <sam <AT> gentoo.org> Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org> ebuild-writing/common-mistakes/text.xml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml index 6f33248..9455688 100644 --- a/ebuild-writing/common-mistakes/text.xml +++ b/ebuild-writing/common-mistakes/text.xml @@ -176,13 +176,14 @@ Always check that it's really gone in the build log. <p><b>Specific -Werror=... flags</b></p> <p> -GCC can turn any specific warning into an error. A specific -Werror flag would -be "-Werror=implicit-function-declaration" for example and will only affect -warnings about implicit function declarations. It's mostly safe to leave these -untouched, cause they are pinned to this issue and should not cause random -build time breakage. Also, we can expect that upstream did this on purpose to -avoid known runtime errors and not just for testing their builds. However you -should check the specified warnings yourself or ask other developers if unsure. +The compiler (e.g. GCC) can turn any specific warning into an error. A +specific -Werror flag would be "-Werror=implicit-function-declaration" for +example and will only affect warnings about implicit function declarations. It's +mostly safe to leave these untouched, cause they are pinned to this issue and +should not cause random build time breakage. Also, we can expect that upstream +did this on purpose to avoid known runtime errors and not just for testing their +builds. However, you should check the specified warnings yourself or ask other +developers if unsure. </p> <p><b>Exceptions</b></p>
