commit:     8e9639e43323449a7193ef717c85b47c70a82877
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Thu Mar 25 14:36:38 2021 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Thu Mar 25 14:39:22 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e9639e4

dev-libs/hyperscan: fix cpu_flags_* default (disable)

We shouldn't enable CPU_FLAGS_* by default. Users don't
mask or explicitly disable flags they don't have, they just
enable the ones they _do_ have.

Even in this case, where we NEED SSSE3, it's wrong to
default it on rather than making the user aware of the
requirement.

Reported-by: ggabriel
Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-libs/hyperscan/hyperscan-5.3.0.ebuild | 4 +++-
 dev-libs/hyperscan/hyperscan-5.4.0.ebuild | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/dev-libs/hyperscan/hyperscan-5.3.0.ebuild 
b/dev-libs/hyperscan/hyperscan-5.3.0.ebuild
index 84f3d508c03..e05b00364aa 100644
--- a/dev-libs/hyperscan/hyperscan-5.3.0.ebuild
+++ b/dev-libs/hyperscan/hyperscan-5.3.0.ebuild
@@ -14,7 +14,7 @@ HOMEPAGE="https://www.hyperscan.io/ 
https://github.com/intel/hyperscan";
 LICENSE="BSD"
 SLOT="0"
 KEYWORDS="amd64 x86"
-IUSE="cpu_flags_x86_avx2 +cpu_flags_x86_ssse3 static-libs"
+IUSE="cpu_flags_x86_avx2 cpu_flags_x86_ssse3 static-libs"
 
 RDEPEND="dev-libs/boost"
 DEPEND="${RDEPEND}"
@@ -23,6 +23,8 @@ BDEPEND="
        dev-util/ragel
 "
 
+# We can't default this to on as it's against the expectation of
+# how CPU_FLAGS_* work for users.
 REQUIRED_USE="cpu_flags_x86_ssse3"
 
 src_prepare() {

diff --git a/dev-libs/hyperscan/hyperscan-5.4.0.ebuild 
b/dev-libs/hyperscan/hyperscan-5.4.0.ebuild
index 6e40c26f0f8..9cd4cf02b42 100644
--- a/dev-libs/hyperscan/hyperscan-5.4.0.ebuild
+++ b/dev-libs/hyperscan/hyperscan-5.4.0.ebuild
@@ -14,7 +14,7 @@ HOMEPAGE="https://www.hyperscan.io/ 
https://github.com/intel/hyperscan";
 LICENSE="BSD"
 SLOT="0"
 KEYWORDS="amd64 x86"
-IUSE="cpu_flags_x86_avx2 +cpu_flags_x86_ssse3 static-libs"
+IUSE="cpu_flags_x86_avx2 cpu_flags_x86_ssse3 static-libs"
 
 RDEPEND="dev-libs/boost:="
 DEPEND="${RDEPEND}"
@@ -23,6 +23,8 @@ BDEPEND="
        dev-util/ragel
 "
 
+# We can't default this to on as it's against the expectation of
+# how CPU_FLAGS_* work for users.
 REQUIRED_USE="cpu_flags_x86_ssse3"
 
 src_prepare() {

Reply via email to