commit:     786ecd5f4c84942af2dc178c2ac9fcaab224a7c9
Author:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
AuthorDate: Sun Mar 21 15:09:41 2021 +0000
Commit:     Mike Gilbert <floppym <AT> gentoo <DOT> org>
CommitDate: Sun Mar 21 15:09:41 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=786ecd5f

app-admin/sudo: remove obsolete comments

The built-in secure_path should be viewed as a reasonable fallback.
The sysadmin may in fact customize it via sudoers at runtime.

Also drop the useless einfo output: this function takes a fraction of a
second to complete, and there is no need for a status message.

Bug: https://bugs.gentoo.org/777267
Signed-off-by: Mike Gilbert <floppym <AT> gentoo.org>

 app-admin/sudo/sudo-1.9.6_p1-r1.ebuild | 7 -------
 app-admin/sudo/sudo-9999.ebuild        | 7 -------
 2 files changed, 14 deletions(-)

diff --git a/app-admin/sudo/sudo-1.9.6_p1-r1.ebuild 
b/app-admin/sudo/sudo-1.9.6_p1-r1.ebuild
index 6f0b7c8646a..32c7ad77309 100644
--- a/app-admin/sudo/sudo-1.9.6_p1-r1.ebuild
+++ b/app-admin/sudo/sudo-1.9.6_p1-r1.ebuild
@@ -80,11 +80,6 @@ src_prepare() {
 }
 
 set_secure_path() {
-       # FIXME: secure_path is a compile time setting. using PATH or
-       # ROOTPATH is not perfect, env-update may invalidate this, but until it
-       # is available as a sudoers setting this will have to do.
-       einfo "Setting secure_path ..."
-
        # first extract the default ROOTPATH from build env
        SECURE_PATH=$(unset ROOTPATH; . "${EPREFIX}"/etc/profile.env;
                echo "${ROOTPATH}")
@@ -122,8 +117,6 @@ set_secure_path() {
                SECURE_PATH=${newpath#:}
        }
        rmpath '*/gcc-bin/*' '*/gnat-gcc-bin/*' '*/gnat-gcc/*'
-
-       einfo "... done"
 }
 
 src_configure() {

diff --git a/app-admin/sudo/sudo-9999.ebuild b/app-admin/sudo/sudo-9999.ebuild
index 6f0b7c8646a..32c7ad77309 100644
--- a/app-admin/sudo/sudo-9999.ebuild
+++ b/app-admin/sudo/sudo-9999.ebuild
@@ -80,11 +80,6 @@ src_prepare() {
 }
 
 set_secure_path() {
-       # FIXME: secure_path is a compile time setting. using PATH or
-       # ROOTPATH is not perfect, env-update may invalidate this, but until it
-       # is available as a sudoers setting this will have to do.
-       einfo "Setting secure_path ..."
-
        # first extract the default ROOTPATH from build env
        SECURE_PATH=$(unset ROOTPATH; . "${EPREFIX}"/etc/profile.env;
                echo "${ROOTPATH}")
@@ -122,8 +117,6 @@ set_secure_path() {
                SECURE_PATH=${newpath#:}
        }
        rmpath '*/gcc-bin/*' '*/gnat-gcc-bin/*' '*/gnat-gcc/*'
-
-       einfo "... done"
 }
 
 src_configure() {

Reply via email to