commit:     a3f90c1d4c4b957fa6fe8a74d3a430c5cf89a7bf
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Sun Jan  3 16:26:35 2021 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Sun Jan  3 16:26:56 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a3f90c1d

media-libs/kquickimageeditor: Drop -Werror

Closes: https://bugs.gentoo.org/763291
Package-Manager: Portage-3.0.12, Repoman-3.0.2
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>

 .../files/kquickimageeditor-0.1.2-no-werror.patch  | 34 ++++++++++++++++++++++
 .../kquickimageeditor-0.1.2.ebuild                 |  2 ++
 2 files changed, 36 insertions(+)

diff --git 
a/media-libs/kquickimageeditor/files/kquickimageeditor-0.1.2-no-werror.patch 
b/media-libs/kquickimageeditor/files/kquickimageeditor-0.1.2-no-werror.patch
new file mode 100644
index 00000000000..69448ea2e70
--- /dev/null
+++ b/media-libs/kquickimageeditor/files/kquickimageeditor-0.1.2-no-werror.patch
@@ -0,0 +1,34 @@
+From c79657496326c10f81cf80a8c9a0e55bc2ba2798 Mon Sep 17 00:00:00 2001
+From: Nicolas Fella <[email protected]>
+Date: Mon, 7 Dec 2020 14:34:09 +0100
+Subject: [PATCH] Remove -Werror
+
+It's doing more harm than good.
+
+It makes it a pain to update anything (compiler, dependencies etc) that
+may introduce new warnings. It also makes it hard to use a compiler that
+produces a lot of warnings, e.g. clazy
+---
+ src/CMakeLists.txt | 6 ------
+ 1 file changed, 6 deletions(-)
+
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 301c05e..99b0a87 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -33,12 +33,6 @@ add_library(
+     ${sources} ${pluginData}
+ )
+ 
+-target_compile_options(
+-    kquickimageeditorplugin
+-    PRIVATE
+-        -Werror
+-)
+-
+ target_link_libraries(
+     kquickimageeditorplugin
+     PRIVATE
+-- 
+2.30.0
+

diff --git a/media-libs/kquickimageeditor/kquickimageeditor-0.1.2.ebuild 
b/media-libs/kquickimageeditor/kquickimageeditor-0.1.2.ebuild
index 639fb329672..eb897f7b47c 100644
--- a/media-libs/kquickimageeditor/kquickimageeditor-0.1.2.ebuild
+++ b/media-libs/kquickimageeditor/kquickimageeditor-0.1.2.ebuild
@@ -19,6 +19,8 @@ fi
 LICENSE="LGPL-2.1+"
 SLOT="5"
 
+PATCHES=( "${FILESDIR}"/${P}-no-werror.patch )
+
 DEPEND="
        >=dev-qt/qtdeclarative-${QTMIN}:5
 "

Reply via email to