commit:     56470165472b6d99db739c36b1ceef77b080706c
Author:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
AuthorDate: Tue Nov 10 22:21:59 2020 +0000
Commit:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
CommitDate: Tue Nov 10 22:22:22 2020 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=56470165

dev-libs/libffi: drop no-op pkg_setup()

Due to a bug in handling empty ${ROOT} pkg_setup() was a no-op.
It's not a big problem as it used to check for libffi presence
outside package manager (usually due to old gcc bundlibg libffi).

The check should should be redundant on modern toolchain.

Reported-by: Pacho Ramos
Closes: https://bugs.gentoo.org/753821
Package-Manager: Portage-3.0.9, Repoman-3.0.2
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>

 dev-libs/libffi/libffi-3.3-r2.ebuild | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/dev-libs/libffi/libffi-3.3-r2.ebuild 
b/dev-libs/libffi/libffi-3.3-r2.ebuild
index 19e01b0832d..0b379dac2a4 100644
--- a/dev-libs/libffi/libffi-3.3-r2.ebuild
+++ b/dev-libs/libffi/libffi-3.3-r2.ebuild
@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
-inherit multilib multilib-minimal toolchain-funcs
+inherit multilib multilib-minimal
 
 MY_PV=${PV/_rc/-rc}
 MY_P=${PN}-${MY_PV}
@@ -38,20 +38,6 @@ S=${WORKDIR}/${MY_P}
 
 ECONF_SOURCE=${S}
 
-pkg_setup() {
-       # Check for orphaned libffi, see https://bugs.gentoo.org/354903 for 
example
-       if [[ ${ROOT} == "/" && ${EPREFIX} == "" ]] && ! has_version 
${CATEGORY}/${PN}; then
-               local base="${T}"/conftest
-               echo 'int main() { }' > "${base}".c
-               $(tc-getCC) -o "${base}" "${base}".c -lffi >&/dev/null
-               if [ $? -eq 0 ]; then
-                       eerror "The linker reported linking against -lffi to be 
working while it shouldn't have."
-                       eerror "This is wrong and you should find and delete 
the old copy of libffi before continuing."
-                       die "The system is in inconsistent state with unknown 
libffi installed."
-               fi
-       fi
-}
-
 multilib_src_configure() {
        use userland_BSD && export HOST="${CHOST}"
        # --includedir= path maintains a few properties:

Reply via email to