vapier 14/08/13 04:36:24
Added: checkbashisms-2.0.0.2-version.patch
checkbashisms-2.0.0.2-kill.patch
checkbashisms-2.0.0.2-export.patch
Log:
Fix kill/export false positives #458392 by Julian Ospald.
(Portage version: 2.2.10/cvs/Linux x86_64, signed Manifest commit with key
D2E96200)
Revision Changes Path
1.1
dev-util/checkbashisms/files/checkbashisms-2.0.0.2-version.patch
file :
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-util/checkbashisms/files/checkbashisms-2.0.0.2-version.patch?rev=1.1&view=markup
plain:
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-util/checkbashisms/files/checkbashisms-2.0.0.2-version.patch?rev=1.1&content-type=text/plain
Index: checkbashisms-2.0.0.2-version.patch
===================================================================
https://sourceforge.net/p/checkbaskisms/checkbashisms/1/
--- a/checkbashisms
+++ b/checkbashisms
@@ -30,7 +30,7 @@
EOF
my $version = <<"EOF";
-This is $progname version 2.0.0.1
+This is $progname version 2.0.0.2
(C) Copyright 1998-2003 Richard Braakman, Josip Rodin and Julian Gilbey
Additional programming by Mark Hobley
EOF
1.1
dev-util/checkbashisms/files/checkbashisms-2.0.0.2-kill.patch
file :
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-util/checkbashisms/files/checkbashisms-2.0.0.2-kill.patch?rev=1.1&view=markup
plain:
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-util/checkbashisms/files/checkbashisms-2.0.0.2-kill.patch?rev=1.1&content-type=text/plain
Index: checkbashisms-2.0.0.2-kill.patch
===================================================================
`kill -HUP` is valid in POSIX
we could extend the check to look for valid signal names, but that seems like
it's not worth the effort (when the # of signals is >30). if the code uses a
wrong signal name, then it'll hit a runtime error regardless of shell.
https://sourceforge.net/p/checkbaskisms/checkbashisms/5/
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/kill.html
https://bugs.gentoo.org/458392
--- a/checkbashisms
+++ b/checkbashisms
@@ -496,7 +496,6 @@
qr'\&>' => q<should be \>word 2\>&1>,
qr'(<\&|>\&)\s*((-|\d+)[^\s;|)}`&\\\\]|[^-\d\s]+(?<!\$)(?!\d))' =>
q<should be \>word 2\>&1>,
- $LEADIN . qr'kill\s+-[^sl]\w*' => q<kill -[0-9] or -[A-Z]>,
$LEADIN . qr'trap\s+["\']?.*["\']?\s+.*[1-9]' => q<trap with signal
numbers>,
$LEADIN . qr'trap\s+["\']?.*["\']?\s+.*ERR' => q<trap ERR>,
qr'\[\[(?!:)' => q<alternative test command ([[ foo ]] should be [ foo
])>,
1.1
dev-util/checkbashisms/files/checkbashisms-2.0.0.2-export.patch
file :
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-util/checkbashisms/files/checkbashisms-2.0.0.2-export.patch?rev=1.1&view=markup
plain:
http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-util/checkbashisms/files/checkbashisms-2.0.0.2-export.patch?rev=1.1&content-type=text/plain
Index: checkbashisms-2.0.0.2-export.patch
===================================================================
`export foor=bar` is valid in POSIX
https://sourceforge.net/p/checkbaskisms/checkbashisms/9/
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#export
https://bugs.gentoo.org/458392
--- a/checkbashisms
+++ b/checkbashisms
@@ -512,7 +512,6 @@
$LEADIN . qr'disown\s' => q<disown>,
$LEADIN . qr'enable\s' => q<enable>,
$LEADIN . qr'export\s+-[^p]' => q<export only takes -p as an option>,
- $LEADIN . qr'export\s+.+=' => q<export foo=bar should be foo=bar;
export foo>,
$LEADIN . qr'mapfile\s' => q<mapfile>,
$LEADIN . qr'readarray\s' => q<readarray>,
$LEADIN . qr'readonly\s+-[af]' => q<readonly -[af]>,
