commit: 0c691939a77d0056ced7f06d5142c1952f917fee Author: Fabian Groffen <grobian <AT> gentoo <DOT> org> AuthorDate: Fri Jan 17 08:21:07 2020 +0000 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org> CommitDate: Fri Jan 17 08:21:07 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=0c691939
libq/tree: avoid double free in sorted case for tree_next_pkg_int Thanks Georgy Yakovlev for the report with stacktrace. Bug: https://bugs.gentoo.org/705636 Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org> libq/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libq/tree.c b/libq/tree.c index 0b01f14..0df2e0d 100644 --- a/libq/tree.c +++ b/libq/tree.c @@ -403,7 +403,7 @@ tree_next_pkg_int(tree_cat_ctx *cat_ctx) pkg_ctx = cat_ctx->pkg_ctxs[cat_ctx->pkg_cnt++] = tree_open_pkg(cat_ctx, name); if (pkg_ctx == NULL) { - free(name); + /* name was freed by tree_close_pkg on fail */ cat_ctx->pkg_cnt--; } }
