commit:     ee2e8e8d65713760f85664bcb004e67aed8228d3
Author:     i.Dark_Templar <darktemplar <AT> dark-templar-archives <DOT> net>
AuthorDate: Mon May 27 20:23:18 2019 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Tue May 28 01:45:04 2019 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=ee2e8e8d

Don't modify /etc/mtab from temporary namespaces

These records are never removed and just pollute
/etc/mtab if that's a regular file.
And if /etc/mtab isn't a regular file,
then attempts to modify it are pointless.

Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>

 lib/portage/process.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/portage/process.py b/lib/portage/process.py
index 0dba55de3..dfbda75de 100644
--- a/lib/portage/process.py
+++ b/lib/portage/process.py
@@ -617,7 +617,7 @@ def _exec(binary, mycommand, opt_name, fd_pipes,
                                                                os._exit(1)
                                                        # mount new /proc for 
our namespace
                                                        s = 
subprocess.Popen(['mount',
-                                                               '-t', 'proc', 
'proc', '/proc'])
+                                                               '-n', '-t', 
'proc', 'proc', '/proc'])
                                                        mount_ret = s.wait()
                                                        if mount_ret != 0:
                                                                
writemsg("Unable to mount new /proc: %d\n" % (mount_ret,),

Reply via email to