commit: e54bc64a3779d4546b70a7a82d677a18d3c37b67 Author: Arfrever Frehtes Taifersar Arahesis <Arfrever <AT> Apache <DOT> Org> AuthorDate: Fri May 10 01:20:14 2019 +0000 Commit: Zac Medico <zmedico <AT> gentoo <DOT> org> CommitDate: Mon May 20 04:53:48 2019 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=e54bc64a
install-qa-check.d/80libraries: fix false positive Do not report libraries missing DT_NEEDED and not containing undefined non-weak symbols. Bug: https://bugs.gentoo.org/516016 Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever <AT> Apache.Org> Signed-off-by: Zac Medico <zmedico <AT> gentoo.org> bin/install-qa-check.d/80libraries | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries index bbabc0eb9..d1d2c4fdd 100644 --- a/bin/install-qa-check.d/80libraries +++ b/bin/install-qa-check.d/80libraries @@ -1,7 +1,15 @@ # Check for issues with installed libraries scanelf_lib_check() { - local f x i j + local t v + for t in NM:nm ; do + v=${t%:*} # NM + t=${t#*:} # nm + eval ${v}=\"${!v:-${CHOST}-${t}}\" + type -P -- ${!v} >/dev/null || eval ${v}=${t} + done + + local f x i j library libraries # Check for shared libraries lacking SONAMEs local qa_var="QA_SONAME_${ARCH/-/_}" @@ -40,7 +48,16 @@ scanelf_lib_check() { # Check for shared libraries lacking NEEDED entries qa_var="QA_DT_NEEDED_${ARCH/-/_}" eval "[[ -n \${!qa_var} ]] && QA_DT_NEEDED=(\"\${${qa_var}[@]}\")" - f=$(scanelf -ByF '%n %p' "${ED%/}"/{,usr/}lib*/lib*.so* | awk '$2 == "" { print }' | sed -e "s:^[[:space:]]${ED%/}/:/:") + f= + libraries=$(scanelf -ByF '%n %p' "${ED%/}"/{,usr/}lib*/lib*.so* | awk '$2 == "" { print }' | sed -e "s:^[[:space:]]::") + if [[ -n ${libraries} ]] ; then + while IFS= read -r library ; do + # Only shared libraries containing undefined non-weak symbols actually need NEEDED entries. + if [[ -n $(${NM} -D "${library}" | grep -E "^ +U ") ]] ; then + f+="/${library#${ED%/}/}"$'\n' + fi + done <<< "${libraries}" + fi if [[ -n ${f} ]] ; then echo "${f}" > "${T}"/scanelf-missing-NEEDED.log if [[ "${QA_STRICT_DT_NEEDED-unset}" == unset ]] ; then
