[gentoo-commits] proj/netifrc:master commit in: init.d/

[Robin H. Johnson]

commit:     c88734624727231da02a3f610c9af0fda70fc1d0
Author:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
AuthorDate: Sun Apr 21 05:23:22 2019 +0000
Commit:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
CommitDate: Sun Apr 21 05:33:35 2019 +0000
URL:        https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=c8873462

init.d/net.lo.in: shellcheck: PROVIDEDBY MODULE trample

This is a logic error caught by shellcheck. The nested loops used the
same index variable, so the outer loop progress could get trampled.

Signed-off-by: Robin H. Johnson <robbat2 <AT> gentoo.org>

 init.d/net.lo.in | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/init.d/net.lo.in b/init.d/net.lo.in
index 961d9fa..a958598 100644
--- a/init.d/net.lo.in
+++ b/init.d/net.lo.in
@@ -369,14 +369,14 @@ _gen_module_list()
                VISITED="${VISITED} $1"
 
                eval AFTER=\$${1}_after
-               for MODULE in ${AFTER}; do
-                       eval PROVIDEDBY=\$${MODULE}_providedby
+               for MODULE1 in ${AFTER}; do
+                       eval PROVIDEDBY=\$${MODULE1}_providedby
                        if [ -n "${PROVIDEDBY}" ]; then
-                               for MODULE in ${PROVIDEDBY}; do
-                                       visit "${MODULE}"
+                               for MODULE2 in ${PROVIDEDBY}; do
+                                       visit "${MODULE2}"
                                done
                        else
-                               visit "${MODULE}"
+                               visit "${MODULE1}"
                        fi
                done