[gentoo-commits] proj/openrc:master commit in: src/rc/

[William Hubbs]

commit:     7185e242ffaa8cd1b672fe4726502a196fd779c2
Author:     Sergei Trofimovich <slyfox <AT> inbox <DOT> ru>
AuthorDate: Tue May 30 07:47:55 2017 +0000
Commit:     William Hubbs <williamh <AT> gentoo <DOT> org>
CommitDate: Tue May 30 07:47:55 2017 +0000
URL:        https://gitweb.gentoo.org/proj/openrc.git/commit/?id=7185e242

rc-logger.c: fix crash on fclose(NULL) (#137)

Only close the log if we successfully opened it.

Reported-by: Brian Evans <grknight <AT> gentoo.org>
Tested-by: Brian Evans <grknight <AT> gentoo.org>
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>

 src/rc/rc-logger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rc/rc-logger.c b/src/rc/rc-logger.c
index b4bd0eae..062ce3d9 100644
--- a/src/rc/rc-logger.c
+++ b/src/rc/rc-logger.c
@@ -261,12 +261,12 @@ rc_logger_open(const char *level)
                                                break;
                                        }
                                }
+                               fclose(log);
                        } else {
                                log_error = 1;
                                eerror("Error: fopen(%s) failed: %s", TMPLOG, 
strerror(errno));
                        }
 
-                       fclose(log);
                        fclose(plog);
                } else {
                        /*