commit:     1d902702b6356287e3182ed199aaffccd42c34f2
Author:     Alexis Ballier <aballier <AT> gentoo <DOT> org>
AuthorDate: Thu Jun 23 09:00:28 2016 +0000
Commit:     Alexis Ballier <aballier <AT> gentoo <DOT> org>
CommitDate: Thu Jun 23 11:23:27 2016 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d902702

Revert "dev-ml/lablgl: Remove another := slot op from || dep"

This reverts commit 9675d96cfe244033e97dd7034b95c5af251405e3.

This commit is wrong in several aspects:
  - Such changes should come with a revbump
  - Removing := deps causes packages not to be rebuilt on upgrades, causing
    barely understandable build failures when upgrading, later on.
    Thanks to this commit, people that have installed those packages will
    likely experience those failures with the upcoming ocaml 4.03 unmask.
  - This is a non maintainer commit where no discussion at all happened with the
    maintainers during the 3 days between bug report and mass commit.
    Such discussion could have prevented the above mentioned breakage.

Proper fix is to drop the backward compatibility part of the || () dep. This fix
was slowly moving forward whenever possible and noticed. Main blocker for this 
is
bug #463018 which requires taking extra care for not breaking the stable tree
nor needlessly preventing future stabilization of packages.

 dev-ml/lablgl/lablgl-1.05.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dev-ml/lablgl/lablgl-1.05.ebuild b/dev-ml/lablgl/lablgl-1.05.ebuild
index 33ec477..bb69c5d 100644
--- a/dev-ml/lablgl/lablgl-1.05.ebuild
+++ b/dev-ml/lablgl/lablgl-1.05.ebuild
@@ -24,7 +24,7 @@ RDEPEND="
        tk? (
                >=dev-lang/tcl-8.3:0=
                >=dev-lang/tk-8.3:0=
-               || ( dev-ml/labltk <dev-lang/ocaml-4.02[tk] )
+               || ( dev-ml/labltk:= <dev-lang/ocaml-4.02[tk] )
        )
        "
 

Reply via email to