commit:     6ba56ad7be84b18dcbf15e8c6b283f5a9a559123
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Sat Dec 12 21:54:22 2015 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Sun Dec 13 16:51:39 2015 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=6ba56ad7

config.environ: remove redundant check for nonexistent keys

Fixes: 39d81c514c33 ("[...]config.__getitem__(): Partially drop backward 
compatibility for nonexistent keys.")

 pym/portage/package/ebuild/config.py | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/pym/portage/package/ebuild/config.py 
b/pym/portage/package/ebuild/config.py
index cc431fc..125d979 100644
--- a/pym/portage/package/ebuild/config.py
+++ b/pym/portage/package/ebuild/config.py
@@ -2712,12 +2712,9 @@ class config(object):
                                filter_calling_env = True
 
                environ_whitelist = self._environ_whitelist
-               for x in self:
+               for x, myvalue in self.iteritems():
                        if x in environ_filter:
                                continue
-                       myvalue = self.get(x)
-                       if myvalue is None:
-                               continue
                        if not isinstance(myvalue, basestring):
                                writemsg(_("!!! Non-string value in config: 
%s=%s\n") % \
                                        (x, myvalue), noiselevel=-1)

Reply via email to