commit:     de7d184909d561b68b411325d32471c047549bca
Author:     William Hubbs <w.d.hubbs <AT> gmail <DOT> com>
AuthorDate: Tue Apr 21 23:30:26 2015 +0000
Commit:     William Hubbs <williamh <AT> gentoo <DOT> org>
CommitDate: Tue Apr 21 23:30:26 2015 +0000
URL:        https://gitweb.gentoo.org/proj/openrc.git/commit/?id=de7d1849

savecache: fix check for $RC_LIBEXECDIR writability

We were originally checking to see if $RC_LIBEXECDIR/cache was writable. For
a new install, this check will fail since this path does not exist. This
is also incorrect because later we create $RC_LIBEXECDIR/cache.

The correct check is checkpath -W $RC_LIBEXECDIR, and this fixes the
issue.

X-Gentoo-Bug: 544632
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=544632

 init.d/savecache.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/init.d/savecache.in b/init.d/savecache.in
index 4fcf3db..9040732 100644
--- a/init.d/savecache.in
+++ b/init.d/savecache.in
@@ -13,8 +13,8 @@ start()
                        return 1
                fi
        fi
-       if [ -e "$RC_LIBEXECDIR"/cache ] && ! checkpath -W 
"$RC_LIBEXECDIR"/cache; then
-               ewarn "WARNING: ${RC_LIBEXECDIR}/cache is not writable!"
+       if ! checkpath -W "$RC_LIBEXECDIR"; then
+               ewarn "WARNING: ${RC_LIBEXECDIR} is not writable!"
                if ! yesno "${RC_GOINGDOWN}"; then
                        ewarn "Unable to save deptree cache"
                        return 1

Reply via email to