commit:     fbe7833d777f3b577e5d2f6cc7ed116c3a776cad
Author:     Nicolas PARLANT <nicolas.parlant <AT> parhuet <DOT> fr>
AuthorDate: Thu Feb 26 13:32:24 2026 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Feb 27 15:19:02 2026 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fbe7833d

dev-libs/libofx: fix cxxflags, filter-lto

fix cxxflags overrided by cflags in configure.ac
bundled tree.hh could be updated but c++14 is required anyway by
libxmlpp:2.6
filter-lto (ODR)

Closes: https://bugs.gentoo.org/967003
Signed-off-by: Nicolas PARLANT <nicolas.parlant <AT> parhuet.fr>
Part-of: https://codeberg.org/gentoo/gentoo/pulls/155
Merges: https://codeberg.org/gentoo/gentoo/pulls/155
Signed-off-by: Sam James <sam <AT> gentoo.org>

 dev-libs/libofx/files/libofx-0.10.9-fix_cxxflags.patch | 15 +++++++++++++++
 dev-libs/libofx/libofx-0.10.9-r1.ebuild                |  3 +++
 2 files changed, 18 insertions(+)

diff --git a/dev-libs/libofx/files/libofx-0.10.9-fix_cxxflags.patch 
b/dev-libs/libofx/files/libofx-0.10.9-fix_cxxflags.patch
new file mode 100644
index 000000000000..96ca184b342e
--- /dev/null
+++ b/dev-libs/libofx/files/libofx-0.10.9-fix_cxxflags.patch
@@ -0,0 +1,15 @@
+See PR pending https://github.com/libofx/libofx/pull/104.patch
+fix typo(?) CFLAGS -> CXXFLAGS
+This prevents the addition of C flags not compatible with CXX
+Fix bug 967003 where -std=c++14 is overrided by CFLAGS
+--- a/configure.ac
++++ b/configure.ac
+@@ -45,7 +45,7 @@ then
+                         [Define if GCC visibility extensions are supported])
+       VISIBILITY_FLAGS="-fvisibility=hidden"
+       CFLAGS="$VISIBILITY_FLAGS $CFLAGS"
+-      CXXFLAGS="$VISIBILITY_FLAGS -fvisibility-inlines-hidden $CFLAGS"
++      CXXFLAGS="$VISIBILITY_FLAGS -fvisibility-inlines-hidden $CXXFLAGS"
+ fi
+ 
+ ## Pass -DIN_LIBOFX to the compiler so we can detect it and include config.h

diff --git a/dev-libs/libofx/libofx-0.10.9-r1.ebuild 
b/dev-libs/libofx/libofx-0.10.9-r1.ebuild
index 2efd93efa646..ca9b3bbd7019 100644
--- a/dev-libs/libofx/libofx-0.10.9-r1.ebuild
+++ b/dev-libs/libofx/libofx-0.10.9-r1.ebuild
@@ -35,6 +35,7 @@ PATCHES=(
        "${FILESDIR}"/${P}-curl.patch
        "${FILESDIR}"/${P}-dtd.patch
        "${FILESDIR}"/${PN}-0.10.9-parallel-build-help2man.patch
+       "${FILESDIR}"/${PN}-0.10.9-fix_cxxflags.patch
 )
 
 src_prepare() {
@@ -46,6 +47,8 @@ src_prepare() {
 src_configure() {
        # bug #566456
        append-cxxflags -std=c++14
+       # -Werror=odr
+       filter-lto
 
        econf $(use_enable doc html-docs)
 }

Reply via email to