commit:     58e7c993c3661e0d36ae51088ce1475b76de79cd
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Jan  9 16:47:05 2026 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri Jan  9 16:47:05 2026 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=58e7c993

gpkg: add brief commentary wrt GnuPG return code

We already have some of this elsewhere, but while here..

Signed-off-by: Sam James <sam <AT> gentoo.org>

 lib/portage/gpkg.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/portage/gpkg.py b/lib/portage/gpkg.py
index 53c43585e3..4984455305 100644
--- a/lib/portage/gpkg.py
+++ b/lib/portage/gpkg.py
@@ -649,12 +649,12 @@ class checksum_helper:
 
         if return_code == os.EX_OK:
             if self.gpg_operation == checksum_helper.VERIFY:
+                # os.EX_OK isn't a guarantee of everything being fine,
+                # so do more checks with `status-fd` output.
                 self._check_gpg_status(self.gpg_result)
             return
 
-        gpg_error_lines = self.gpg_result.decode(
-            "UTF-8", errors="replace"
-        ).splitlines()
+        gpg_error_lines = self.gpg_result.decode("UTF-8", 
errors="replace").splitlines()
 
         if self.gpg_operation == checksum_helper.SIGNING:
             self.show_gpg_error(checksum_helper.SIGNING, gpg_error_lines)

Reply via email to