commit: aed70ea3e097e20b9e5fdc27a6af7541f728794a
Author: Kerin Millar <kfm <AT> plushkava <DOT> net>
AuthorDate: Fri May 30 23:43:32 2025 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun Jun 1 21:42:02 2025 +0000
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=aed70ea3
Add shellcheck hints to scripts without shebangs
Signed-off-by: Kerin Millar <kfm <AT> plushkava.net>
Signed-off-by: Sam James <sam <AT> gentoo.org>
bin/install-qa-check.d/05double-D | 2 ++
bin/install-qa-check.d/05prefix | 2 ++
bin/install-qa-check.d/10executable-issues | 2 ++
bin/install-qa-check.d/10ignored-flags | 2 ++
bin/install-qa-check.d/20deprecated-directories | 2 ++
bin/install-qa-check.d/20runtime-directories | 2 ++
bin/install-qa-check.d/60bash-completion | 2 ++
bin/install-qa-check.d/60openrc | 2 ++
bin/install-qa-check.d/60pkgconfig | 2 ++
bin/install-qa-check.d/60pngfix | 2 ++
bin/install-qa-check.d/60systemd | 2 ++
bin/install-qa-check.d/60udev | 2 ++
bin/install-qa-check.d/80libraries | 2 ++
bin/install-qa-check.d/80multilib-strict | 3 +++
bin/install-qa-check.d/90bad-bin-group-write | 1 +
bin/install-qa-check.d/90bad-bin-owner | 1 +
bin/install-qa-check.d/90cmake-warnings | 2 ++
bin/install-qa-check.d/90config-impl-decl | 2 ++
bin/install-qa-check.d/90cython-dep | 2 ++
bin/install-qa-check.d/90gcc-warnings | 2 ++
bin/install-qa-check.d/90world-writable | 2 ++
bin/install-qa-check.d/95empty-dirs | 2 ++
bin/postinst-qa-check.d/50xdg-utils | 2 ++
23 files changed, 45 insertions(+)
diff --git a/bin/install-qa-check.d/05double-D
b/bin/install-qa-check.d/05double-D
index f0cefc1479..fd59f6bac5 100644
--- a/bin/install-qa-check.d/05double-D
+++ b/bin/install-qa-check.d/05double-D
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for accidental install into ${D}/${D}
DD_check() {
diff --git a/bin/install-qa-check.d/05prefix b/bin/install-qa-check.d/05prefix
index c1d1c3a0e5..9217113200 100644
--- a/bin/install-qa-check.d/05prefix
+++ b/bin/install-qa-check.d/05prefix
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Prefix specific QA checks
install_qa_check_prefix() {
diff --git a/bin/install-qa-check.d/10executable-issues
b/bin/install-qa-check.d/10executable-issues
index 26df523285..5dc7cec950 100644
--- a/bin/install-qa-check.d/10executable-issues
+++ b/bin/install-qa-check.d/10executable-issues
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for major issues with built executables: insecure RPATHs,
# text relocations, executable stacks
diff --git a/bin/install-qa-check.d/10ignored-flags
b/bin/install-qa-check.d/10ignored-flags
index 6771f59736..5642ff7436 100644
--- a/bin/install-qa-check.d/10ignored-flags
+++ b/bin/install-qa-check.d/10ignored-flags
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# QA checks for ignored *FLAGS.
ignored_flag_check() {
diff --git a/bin/install-qa-check.d/20deprecated-directories
b/bin/install-qa-check.d/20deprecated-directories
index db46962c5e..055b08e674 100644
--- a/bin/install-qa-check.d/20deprecated-directories
+++ b/bin/install-qa-check.d/20deprecated-directories
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for deprecated directories
deprecated_dir_check() {
diff --git a/bin/install-qa-check.d/20runtime-directories
b/bin/install-qa-check.d/20runtime-directories
index fe8d166cf8..352181f4d8 100644
--- a/bin/install-qa-check.d/20runtime-directories
+++ b/bin/install-qa-check.d/20runtime-directories
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for directories that need to be created at runtime
runtime_dir_check() {
diff --git a/bin/install-qa-check.d/60bash-completion
b/bin/install-qa-check.d/60bash-completion
index 9ed209af6a..7a046efe79 100644
--- a/bin/install-qa-check.d/60bash-completion
+++ b/bin/install-qa-check.d/60bash-completion
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# QA checks for bash-completion files
bashcomp_check() {
diff --git a/bin/install-qa-check.d/60openrc b/bin/install-qa-check.d/60openrc
index 8b881d2ff2..8b0ab0a8dd 100644
--- a/bin/install-qa-check.d/60openrc
+++ b/bin/install-qa-check.d/60openrc
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# QA checks for OpenRC init.d files.
openrc_check() {
diff --git a/bin/install-qa-check.d/60pkgconfig
b/bin/install-qa-check.d/60pkgconfig
index fb9bf2551a..f26ae5dffb 100644
--- a/bin/install-qa-check.d/60pkgconfig
+++ b/bin/install-qa-check.d/60pkgconfig
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for pkg-config file issues
# Ensure that ver_test is available.
diff --git a/bin/install-qa-check.d/60pngfix b/bin/install-qa-check.d/60pngfix
index 86ce22f258..0300ed2ac1 100644
--- a/bin/install-qa-check.d/60pngfix
+++ b/bin/install-qa-check.d/60pngfix
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for issues with PNG files
pngfix_check() {
diff --git a/bin/install-qa-check.d/60systemd b/bin/install-qa-check.d/60systemd
index 57fa2990ca..4945fafd18 100644
--- a/bin/install-qa-check.d/60systemd
+++ b/bin/install-qa-check.d/60systemd
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# QA checks for systemd units.
systemd_check() {
diff --git a/bin/install-qa-check.d/60udev b/bin/install-qa-check.d/60udev
index 51ac8a6fe9..eea7a6bb11 100644
--- a/bin/install-qa-check.d/60udev
+++ b/bin/install-qa-check.d/60udev
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check udev rule installs
udev_check() {
diff --git a/bin/install-qa-check.d/80libraries
b/bin/install-qa-check.d/80libraries
index 0e67ea898a..4e55db8b52 100644
--- a/bin/install-qa-check.d/80libraries
+++ b/bin/install-qa-check.d/80libraries
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for issues with installed libraries
scanelf_lib_check() {
diff --git a/bin/install-qa-check.d/80multilib-strict
b/bin/install-qa-check.d/80multilib-strict
index 82a2883f1a..715e39452f 100644
--- a/bin/install-qa-check.d/80multilib-strict
+++ b/bin/install-qa-check.d/80multilib-strict
@@ -1,4 +1,7 @@
+# shellcheck shell=bash
+
# Strict multilib directory checks
+
multilib_strict_check() {
local IFS abort dir file
diff --git a/bin/install-qa-check.d/90bad-bin-group-write
b/bin/install-qa-check.d/90bad-bin-group-write
index 7b5a0c02db..6c53311bf2 100644
--- a/bin/install-qa-check.d/90bad-bin-group-write
+++ b/bin/install-qa-check.d/90bad-bin-group-write
@@ -1,5 +1,6 @@
# Copyright 1999-2018 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
+# shellcheck shell=bash
bad_bin_group_write_check() {
# Warn about globally-installed executables (in /bin, /usr/bin, /sbin,
diff --git a/bin/install-qa-check.d/90bad-bin-owner
b/bin/install-qa-check.d/90bad-bin-owner
index 74255c02f0..e12a6e5eae 100644
--- a/bin/install-qa-check.d/90bad-bin-owner
+++ b/bin/install-qa-check.d/90bad-bin-owner
@@ -1,5 +1,6 @@
# Copyright 1999-2018 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
+# shellcheck shell=bash
bad_bin_owner_check() {
# Warn about globally-installed executables (in /bin, /usr/bin, /sbin,
diff --git a/bin/install-qa-check.d/90cmake-warnings
b/bin/install-qa-check.d/90cmake-warnings
index a1b1e3d1b3..c409dd45ea 100644
--- a/bin/install-qa-check.d/90cmake-warnings
+++ b/bin/install-qa-check.d/90cmake-warnings
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for CMake invalid option warnings
cmake_warn_check() {
diff --git a/bin/install-qa-check.d/90config-impl-decl
b/bin/install-qa-check.d/90config-impl-decl
index 310865a5d1..68950b6292 100644
--- a/bin/install-qa-check.d/90config-impl-decl
+++ b/bin/install-qa-check.d/90config-impl-decl
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for implicit function declaration warnings in configure logs
#
# ebuilds should set the QA_CONFIG_IMPL_DECL_SKIP array to skip known false
diff --git a/bin/install-qa-check.d/90cython-dep
b/bin/install-qa-check.d/90cython-dep
index 3471789f78..d9d40d9f8c 100644
--- a/bin/install-qa-check.d/90cython-dep
+++ b/bin/install-qa-check.d/90cython-dep
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for missing dev-python/cython dep based on output
# from setuptools cythonize() support
diff --git a/bin/install-qa-check.d/90gcc-warnings
b/bin/install-qa-check.d/90gcc-warnings
index 1f51279d97..0b98dd5c5c 100644
--- a/bin/install-qa-check.d/90gcc-warnings
+++ b/bin/install-qa-check.d/90gcc-warnings
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for important gcc warnings
# TODO: adapt for clang?
# TODO: add -Wformat-security
diff --git a/bin/install-qa-check.d/90world-writable
b/bin/install-qa-check.d/90world-writable
index b8252dd909..4c8a156ad0 100644
--- a/bin/install-qa-check.d/90world-writable
+++ b/bin/install-qa-check.d/90world-writable
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for world-writable files
world_writable_check() {
diff --git a/bin/install-qa-check.d/95empty-dirs
b/bin/install-qa-check.d/95empty-dirs
index 348a068206..65cc6d5bf3 100644
--- a/bin/install-qa-check.d/95empty-dirs
+++ b/bin/install-qa-check.d/95empty-dirs
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Warn about and/or remove empty directories installed by ebuild.
# Rationale: PMS prohibits ebuilds from installing empty directories.
diff --git a/bin/postinst-qa-check.d/50xdg-utils
b/bin/postinst-qa-check.d/50xdg-utils
index 6daaba1861..089e664448 100644
--- a/bin/postinst-qa-check.d/50xdg-utils
+++ b/bin/postinst-qa-check.d/50xdg-utils
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+
# Check for missing calls to xdg-utils regen functions
xdg_desktop_database_check() {
