commit:     b2a26e9d7a8bb0a747e00ca1e28b5ad085eb9ae8
Author:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Tue Apr 15 05:31:05 2025 +0000
Commit:     Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Tue Apr 15 05:41:44 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2a26e9d

dev-qt/qtwebengine: ensure execstack is disabled

On second thought, think would rather ensure that this is disabled
even if do not know how it happened in the first place, especially
given chromium itself relies on noexecstack rather than notes, but
then qtwebengine does not pass it for the final linking phase.

Believe this is only an issue for qtwebengine with its multitude
of asm files that may or may not be used, so not doing it in the
eclass.

Not revbumping given it seems to only happen in edge cases, but may
as well get this done before stable 6.8.3 so that if glibc-2.41 is
stabled later it'll ensure it's fine for them.

Closes: https://bugs.gentoo.org/953111
Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>

 dev-qt/qtwebengine/qtwebengine-6.8.3.ebuild    | 4 ++++
 dev-qt/qtwebengine/qtwebengine-6.9.0-r1.ebuild | 4 ++++
 dev-qt/qtwebengine/qtwebengine-6.9.9999.ebuild | 4 ++++
 dev-qt/qtwebengine/qtwebengine-6.9999.ebuild   | 4 ++++
 4 files changed, 16 insertions(+)

diff --git a/dev-qt/qtwebengine/qtwebengine-6.8.3.ebuild 
b/dev-qt/qtwebengine/qtwebengine-6.8.3.ebuild
index 7b688a197a15..bab5e64ddb82 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.8.3.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.8.3.ebuild
@@ -257,6 +257,10 @@ src_configure() {
                use arm64 && tc-is-gcc && filter-flags '-march=*' '-mcpu=*'
        fi
 
+       # chromium passes this by default, but qtwebengine does not and it may
+       # "possibly" get enabled by some paths and cause issues (bug #953111)
+       append-ldflags -Wl,-z,noexecstack
+
        export NINJAFLAGS=$(get_NINJAOPTS)
        [[ ${NINJA_VERBOSE^^} == OFF ]] || NINJAFLAGS+=" -v"
 

diff --git a/dev-qt/qtwebengine/qtwebengine-6.9.0-r1.ebuild 
b/dev-qt/qtwebengine/qtwebengine-6.9.0-r1.ebuild
index d01308b28bb7..81125ccc89f3 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.9.0-r1.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.9.0-r1.ebuild
@@ -255,6 +255,10 @@ src_configure() {
                use arm64 && tc-is-gcc && filter-flags '-march=*' '-mcpu=*'
        fi
 
+       # chromium passes this by default, but qtwebengine does not and it may
+       # "possibly" get enabled by some paths and cause issues (bug #953111)
+       append-ldflags -Wl,-z,noexecstack
+
        export NINJAFLAGS=$(get_NINJAOPTS)
        [[ ${NINJA_VERBOSE^^} == OFF ]] || NINJAFLAGS+=" -v"
 

diff --git a/dev-qt/qtwebengine/qtwebengine-6.9.9999.ebuild 
b/dev-qt/qtwebengine/qtwebengine-6.9.9999.ebuild
index 210f80363379..05000f1cc1ad 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.9.9999.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.9.9999.ebuild
@@ -253,6 +253,10 @@ src_configure() {
                use arm64 && tc-is-gcc && filter-flags '-march=*' '-mcpu=*'
        fi
 
+       # chromium passes this by default, but qtwebengine does not and it may
+       # "possibly" get enabled by some paths and cause issues (bug #953111)
+       append-ldflags -Wl,-z,noexecstack
+
        export NINJAFLAGS=$(get_NINJAOPTS)
        [[ ${NINJA_VERBOSE^^} == OFF ]] || NINJAFLAGS+=" -v"
 

diff --git a/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild 
b/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild
index 1a65a1e73f68..e39783175f0f 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.9999.ebuild
@@ -251,6 +251,10 @@ src_configure() {
                use arm64 && tc-is-gcc && filter-flags '-march=*' '-mcpu=*'
        fi
 
+       # chromium passes this by default, but qtwebengine does not and it may
+       # "possibly" get enabled by some paths and cause issues (bug #953111)
+       append-ldflags -Wl,-z,noexecstack
+
        export NINJAFLAGS=$(get_NINJAOPTS)
        [[ ${NINJA_VERBOSE^^} == OFF ]] || NINJAFLAGS+=" -v"
 

Reply via email to