commit:     a8d1764ceaf0924e76c503efe760c391d0e469da
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Tue Feb 18 03:31:08 2025 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Feb 18 03:38:52 2025 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a8d1764c

net-nds/openldap: drop modern C hacks

* Drop -Wno-error= for 2.5.x. If 2.5.x is actually broken, we need to
  fix it properly. But AFAIK everything is fixed there anyway.

* Drop -Wno-error= comments from 2.6.x.

Bug: https://bugs.gentoo.org/871288
Bug: https://bugs.gentoo.org/920380
Signed-off-by: Sam James <sam <AT> gentoo.org>

 net-nds/openldap/openldap-2.5.19.ebuild   | 11 -----------
 net-nds/openldap/openldap-2.6.8-r1.ebuild |  4 ----
 net-nds/openldap/openldap-2.6.9.ebuild    |  6 +-----
 3 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/net-nds/openldap/openldap-2.5.19.ebuild 
b/net-nds/openldap/openldap-2.5.19.ebuild
index 8d522c18a18b..7bc26053d235 100644
--- a/net-nds/openldap/openldap-2.5.19.ebuild
+++ b/net-nds/openldap/openldap-2.5.19.ebuild
@@ -426,17 +426,6 @@ multilib_src_configure() {
                --without-fetch
        )
 
-       # The configure scripts make some assumptions that aren't valid in 
newer GCC.
-       # https://bugs.gentoo.org/920380
-       append-flags $(test-flags-CC -Wno-error=implicit-int)
-       # conftest.c:113:16: error: passing argument 1 of 'pthread_detach' makes
-       # integer from pointer without a cast [-Wint-conversion]
-       append-flags $(test-flags-CC -Wno-error=int-conversion)
-       # error: passing argument 3 of ‘ldap_bv2rdn’ from incompatible pointer 
type
-       # [-Wincompatible-pointer-types]
-       # expected ‘char **’ but argument is of type ‘const char **’
-       #append-flags $(test-flags-CC -Wno-error=incompatible-pointer-types)
-
        if use experimental ; then
                # connectionless ldap per bug #342439
                # connectionless is a unsupported feature according to Howard 
Chu

diff --git a/net-nds/openldap/openldap-2.6.8-r1.ebuild 
b/net-nds/openldap/openldap-2.6.8-r1.ebuild
index 2c090a4926af..5013213b7f8a 100644
--- a/net-nds/openldap/openldap-2.6.8-r1.ebuild
+++ b/net-nds/openldap/openldap-2.6.8-r1.ebuild
@@ -423,10 +423,6 @@ multilib_src_configure() {
                $(multilib_native_use_with sasl cyrus-sasl)
        )
 
-       # error: passing argument 3 of ‘ldap_bv2rdn’ from incompatible pointer 
type [-Wincompatible-pointer-types]
-       # expected ‘char **’ but argument is of type ‘const char **’
-       #append-flags $(test-flags-CC -Wno-error=incompatible-pointer-types)
-
        if use experimental ; then
                # connectionless ldap per bug #342439
                # connectionless is a unsupported feature according to Howard 
Chu

diff --git a/net-nds/openldap/openldap-2.6.9.ebuild 
b/net-nds/openldap/openldap-2.6.9.ebuild
index 8eb8c5d976fe..c5a5d0bb29b3 100644
--- a/net-nds/openldap/openldap-2.6.9.ebuild
+++ b/net-nds/openldap/openldap-2.6.9.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2024 Gentoo Authors
+# Copyright 1999-2025 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=8
@@ -432,10 +432,6 @@ multilib_src_configure() {
                $(multilib_native_use_with sasl cyrus-sasl)
        )
 
-       # error: passing argument 3 of ‘ldap_bv2rdn’ from incompatible pointer 
type [-Wincompatible-pointer-types]
-       # expected ‘char **’ but argument is of type ‘const char **’
-       #append-flags $(test-flags-CC -Wno-error=incompatible-pointer-types)
-
        if use experimental ; then
                # connectionless ldap per bug #342439
                # connectionless is a unsupported feature according to Howard 
Chu

Reply via email to