+1 (binding)

I reviewed these four source artifacts, each with its .asc and .sha512,
staged at
https://dist.apache.org/repos/dist/dev/incubator/cloudberry/2.2.0-incubating-rc3/

- apache-cloudberry-2.2.0-incubating-src.tar.gz
- apache-cloudberry-backup-2.2.0-incubating-src.tar.gz
- apache-cloudberry-go-libs-2.2.0-incubating-src.tar.gz
- apache-cloudberry-pxf-2.2.0-incubating-src.tar.gz

Checked:

- Download links return each source tarball, its .asc, and its .sha512.
- SHA512 matches on all four.
- GPG against https://downloads.apache.org/incubator/cloudberry/KEYS. Good
signature from Leonid Borchuk on each, key id ending 6ACA3F2B. My keyring
does not certify that key. That warning is not a bad signature.
- Each source filename includes incubating.
- LICENSE, NOTICE, and DISCLAIMER are present in each artifact. I am not
marking that line accurate.

  After the license problems that cancelled rc1 and rc2, the community
review of this candidate named three remaining notice gaps and judged that
none of them requires another candidate. I read those files. I do not see a
-1 in them:
  - contrib/pgcrypto/crypt-md5.c is imported FreeBSD code by Poul-Henning
Kamp. The beer-ware notice is not in the file, and neither Kamp nor the
file is named in the core LICENSE.
  - The Bison-generated parser is gpcontrib/orafce/sqlparse.c and
sqlparse.h. The Bison exception is present. The core LICENSE does not name
Bison.
  - src/pl/plperl/plperl.c copies setlocale_perl from Perl's POSIX.xs. The
copy is wrapped so that it is not compiled on Linux or macOS. The text is
still in the archive.

  I also found a notice gap that was not in that list.
backup/queries_shared.go says some queries were copied from pg_dump, and
the backup LICENSE and NOTICE do not name PostgreSQL. It is the same kind
of gap. I am not voting -1 on it.
- I found no unexpected compiled binaries (.class, .jar, .so, .o, .a, .exe,
.dll) in the source archives. RAT marked other files as binary. Those are
not compiled objects.
- Apache RAT passed on the extracted trees, under the project's own
excludes.
- Built from the extracted tarballs, not from a git checkout:
  - core: configure, make, make install, and contrib install. postgres
--gp-version is "postgres (Apache Cloudberry) 2.2.0-incubating build
13d3c58eaa0", which matches the VERSION file in the tarball. The core
README does not list liburing. The compile guide does. PAX needs it.
  - backup: make depend and make build, from the tarball README. The
binaries report version 2.2.0. I did not use the README's go install line.
That line names 2.1.0-incubating.
  - go-libs: the README has no build section. I ran make depend and make
unit. I did not run the default make, which also lints. There is no
versioned executable.
  - pxf: make against the installed core prefix. I did not run make
install. The version file and the locally built jar say 2.2.0 and do not
say incubating. The release archive names already include incubating. I am
not voting against that.

Not checked:

- I did not compare the tarballs to the git tags by checkout.
- I did not start a cluster or run SQL.
- I did not run the PXF unit tests beyond make.

Nice work Leonid!
-=e

--
Ed Espino
Apache Cloudberry (Incubating)

Reply via email to