-1 binding The source release has a file that includes code from Guava. This needs to be mentioned in the LICENSE file in the root directory of the source release.
https://github.com/apache/incubator-toree/blob/0c35d274aa69e73be3054542fe4e6fda39076bf9/kernel/src/main/scala/org/apache/toree/utils/ClassPath.java#L73 I also think that file should only have the original Guava license header. There is no need to add an Apache source header when the Guava one is an Apache header anyway (except that it includes a copyright). A couple of quibbles with the vote email. * could you use links from lists.apache.org because those mail links give the full thread in an easier to follow way? * you should provide a link in the email to https://downloads.apache.org/incubator/toree/KEYS The source release looks generally ok otherwise. I'm not sure that there are enough 3rd party licenses in toree-assembly-0.6.0-incubating.jar. It makes my heart sink when I see these files in releases because they are a licensing nightmare. This jar has a huge number of classes from lots of different jars, some ASF but many other ones too. The META-INF folder has licenses for many of them but lots of them appear to be missing. There is also a file called LICENSE_toree-assembly-0.6.0-incubating which might be better placed in the META-INF folder which at least provides links to 3rd party licenses but it again seems incomplete. I would favour including all the 3rd party licenses in META-INF explicitly. Ones that appear to missing altogether are: * argonaut * shapeless * jansi * hawtjni * alexarchambault/windowsansi * neilalexander/jnacl On Sun, 19 Oct 2025 at 23:49, Luciano Resende <[email protected]> wrote: > > Please vote to approve the release of Apache Toree 0.6.0-incubating (RC1). > > This new release introduces: > - Support Apache Spark 3.4.4 > - Support for Scala 2.13 > - Migrated to use Apache Pekko instead of Akka > - Update ScalaInterpreter to use context classloader > - Add support to ARM platform on docker images > - Reply message should implement status field > - Fix deadlock on closing ZMQ by upgrading jeromq to 0.5.3 > - Update AddJar command to support AWS S3a cloud storage > - Update AddJar command to support Google cloud storage > - Fire postRunCell event after cell execution > > > The podling dev vote thread: > https://www.mail-archive.com/[email protected]/msg00294.html > > And the result: > https://www.mail-archive.com/[email protected]/msg00295.html > > Tag: v0.6.0-incubating-rc1 (e67ed7ec23446b6ea7bd5a1d77fd8d898f32161b) > > https://github.com/apache/incubator-toree/tree/v0.6.0-incubating-rc1 > > All distribution packages, including signatures, digests, etc. can be found > at: > > https://dist.apache.org/repos/dist/dev/incubator/toree/0.6.0-incubating-rc1/ > > Staging artifacts can be found at: > > https://repository.apache.org/content/repositories/orgapachetoree-1021 > > The vote is open for at least 72 hours and passes if a majority of at least > 3 +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Toree 0.6.0-incubating > [ ] -1 Do not release this package because ... > > -- > Luciano Resende > http://twitter.com/lresende1975 > http://lresende.blogspot.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
