Feng,

Thank you for removing the v2.0.0 tag. I do understand the project
challenges entering incubation with legacy items such as this tag. I am now
switching my vote as it does not impact the source release tarball.

+1 (binding).

The other issues I raised can be addressed in subsequent releases. Please
do not hesitate to reach out if any of the issues need
further clarification.

Regards,
-=ed espino

-- 
Ed Espino
Apache Cloudberry (Incubating) & MADlib


On Tue, Sep 16, 2025 at 10:49 PM Feng Zhang <[email protected]> wrote:

> Hi Ed,
>
> I'm very sorry, the git tag for v2.0.0 in the repository was a leftover
> from the previous release, and I have now deleted it (the previous release
> has been abandoned). Please check again.
>
> In addition, the other issues you mentioned will be resolved before the
> next release.
>
> Thank you.
>
> On 2025/09/13 04:28:30 Ed Espino wrote:
> > VOTE: -1 (binding)
> >
> > I am voting -1 (binding) on this release candidate due to a critical
> > git tag version management issue that must be resolved before release
> > approval. The git repository contains both v2.0.0-rc01 and v2.0.0 tags
> > pointing to different commits, violating tag immutability principles
> > essential for Apache releases.
> >
> > ----------------------------------------------------------------
> > VALIDATION CHECKLIST
> > ----------------------------------------------------------------
> >
> > [x] Download links are valid
> > [x] Checksums and signatures verified
> > [x] LICENSE/NOTICE files exist
> > [x] No unexpected binary files
> > [x] All source files have ASF headers (100% compliance after cosmetic
> >     updates)
> > [x] Can compile from source
> >
> > ----------------------------------------------------------------
> > BLOCKING ISSUE
> > ----------------------------------------------------------------
> >
> > Git Tag Version Management Issue:
> > Repository contains both v2.0.0-rc01 and v2.0.0 tags pointing to
> > different commits, violating git tag immutability principles required
> > for Apache releases.
> >
> > ----------------------------------------------------------------
> > OTHER FINDINGS
> > ----------------------------------------------------------------
> >
> > 1. Code Quality Issues (LOW severity)
> >    - go vet: 12 violations found (primarily in test files)
> >    - Lock copying issues and unkeyed struct literals
> >
> > 2. Missing VERSION File (MEDIUM severity)
> >    - Build system expects VERSION file, missing from source tarball
> >    - Results in empty version metadata in built binaries
> >
> > 3. Documentation Discoverability (MEDIUM severity)
> >    - Go implementation not prominently featured on official website
> >    - Multi-repository ecosystem requires navigation through README
> >      files
> >    - Related repositories not easily discoverable from
> >      https://seata.apache.org/:
> >      * Seata Website -
> https://github.com/apache/incubator-seata.github.io
> >      * Seata GoLang - https://github.com/apache/incubator-seata-go
> >      * Seata Samples - https://github.com/apache/incubator-seata-samples
> >      * Seata GoLang Samples -
> >        https://github.com/apache/incubator-seata-go-samples
> >      * Seata K8s - https://github.com/apache/incubator-seata-k8s
> >      * Seata CLI - https://github.com/apache/incubator-seata-ctl
> >
> >    - Note: Seata GoLang Samples repository could potentially be used
> >      for additional release validation/integration testing
> >
> > 4. Timezone-Dependent Unit Test (LOW-MEDIUM severity)
> >    - pkg/util/flagext/day_test.go fails in western timezones
> >    - Passes in China CST/UTC environments
> >
> > 5. License Header Formatting (LOW severity)
> >    - 2 files required cosmetic license header updates (automatically
> >      corrected by make license)
> >    - pkg/datasource/sql/exec/at/update_join_executor.go
> >    - pkg/datasource/sql/exec/at/update_join_executor_test.go
> >
> > 6. Makefile Git Status Issue (LOW severity)
> >    - makefile assumes git repository context, generates harmless error
> >
> > On Thu, Sep 11, 2025 at 11:12 AM Feng Zhang <[email protected]> wrote:
> >
> > > Hello everyone,
> > >
> > > This is a call for vote to release Apache Seata-go(incubating) v2.0.0.
> > >
> > > The Apache Seata community has voted and approved the release of
> > > Apache Seata-go(incubating) v2.0.0. We now kindly request the IPMC
> members
> > > review and vote for this release.
> > >
> > >
> > > The vote thread:
> > > https://lists.apache.org/thread/zgd2mykscftyqw5gngxnk0c8z37tbk27
> > >
> > > Vote Result:
> > > https://lists.apache.org/thread/zg3l67p09nrrllcy4t3oq77zwohrwklw
> > >
> > >
> > > The release candidates:
> > >
> > >
> https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata-go/2.0.0-RC1/
> > >
> > > Git tag for the release:
> > > https://github.com/apache/incubator-seata-go/releases/tag/v2.0.0-rc01
> > >
> > > Hash for the release tag:
> > > c91a8f53a92777e178e4f7901d7e0e507b3b8dfe
> > >
> > > Release Notes:
> > > https://github.com/apache/incubator-seata-go/releases/tag/v2.0.0-rc01
> > >
> > > The artifacts have been signed with Key [ 17DEE8D9DF0880D5 ], mail [
> > > [email protected] ]
> > >
> > > which can be found in the keys file:
> > > https://downloads.apache.org/incubator/seata/KEYS
> > >
> > > Build Environment: Golang 1.20+.
> > > Build Command: make build
> > >
> > > CI Test Workflow:
> > >
> > >
> https://github.com/apache/incubator-seata-go/actions/runs/16394067144/job/46323822404
> > >
> > >
> https://github.com/apache/incubator-seata-go/actions/runs/17649036261/job/50154789509
> > >
> > > The vote will be open for at least 72 hours.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > > Checklist for reference:
> > > [ ] Download links are valid.
> > > [ ] Checksums and signatures.
> > > [ ] LICENSE/NOTICE files exist
> > > [ ] No unexpected binary files
> > > [ ] All source files have ASF headers
> > > [ ] Can compile from source
> > >
> > >
> > > To learn more about Apache Seata , please see
> https://seata.apache.org/
> > >
> > > Warm regards,
> > >
> > > Feng Zhang
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to