I'm closing the voting thread, carrying my own vote: +1 (non-binding)
[x] Download KIE artifacts are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct. (based on the best of my knowledge) [x] All files have license headers if necessary. (based on the best of my knowledge) [x] No compiled archives bundled in source archive. [x] Can compile from source. On Wed, Jul 2, 2025 at 5:02 PM PJ Fanning <fannin...@apache.org> wrote: > > Thanks Alex for answering my questions. > Please feel free to proceed with the vote - I'm not looking to block any > releases. > > On 2025/07/02 14:55:22 Alex Porcelli wrote: > > Inline... > > > > On Wed, Jul 2, 2025 at 10:34 AM PJ Fanning <fannin...@gmail.com> wrote: > > > > > > There are also a lot of files in the source release that don't have > > > source headers. 3500 or so according to Apache RAT. > > > Some of the files may be .txt or other non-source files but I > > > definitely found a large number of Java and Go files. > > > > > > Examples: > > > https://github.com/apache/incubator-kie-drools/blob/655d49b4c77d28029113afd2526dae85c437b2ef/drools-util/src/main/java/org/drools/util/bitmask/OpenBitSet.java > > > > https://github.com/apache/incubator-kie-drools/blob/main/LICENSE#L242 > > > > > incubator-kie-tools/packages/dashbuilder/appformer/uberfire-workbench/uberfire-workbench-processors-tests/src/test/resources/org/uberfire/annotations/processors/PerspectiveTest1.java > > > (and a number of other Java files in uberfire-workbench subdirs) > > > > Those files are related to "Test data for which the addition of a > > source header would cause the tests to fail." > > > > > > > > Go file - incubator-kie-tools/packages/kn-plugin-workflow/go.mod > > > > This is a config file, need double check if it allows header files. > > > > > Js file - > > > incubator-kie-tools/packages/dashbuilder/appformer/uberfire-extensions/uberfire-widgets/uberfire-widgets-commons/src/main/resources/org/uberfire/ext/widgets/common/client/resources/js/wysihtml/wysihtml.all-commands.min.js > > > > https://github.com/apache/incubator-kie-tools/blob/main/LICENSE#L867 > > > > > > > > I haven't looked at the potentially 3rd party code in detail but it's > > > important that the 3rd party code in the source release is accounted > > > for soon. You can't include any code with Category X licensing even if > > > you have a DISCLAIMER-WIP. > > > > To the best of our community's knowledge, we conducted a thorough > > search of the codebase. We couldn't identify any content that is not > > already included in DISCLAIMER-WIP or License files. > > > > > > > > > > > > > > > > > On Wed, 2 Jul 2025 at 14:52, PJ Fanning <fannin...@gmail.com> wrote: > > > > > > > > Hi Alex, > > > > Would it be possible to see some progress in future RCs on getting the > > > > non-source artifacts in the RC to have LICENSE, NOTICE and DISCLAIMER > > > > files - and ones that are appropriate for each artifact? > > > > I looked at > > > > apache-kie-10.1.0-incubating-business-automation-chrome-extension.zip > > > > and it doesn't have a valid Apache LICENSE or NOTICE. Some of the > > > > source files don't have Apache Source headers. One such file is > > > > background.js. > > > > > > > > I couldn't find that file in your source release > > > > (apache-kie-10.1.0-incubating-sources.zip). Would it be possible to > > > > get some background on why it isn't in the source release? > > > > > > > > I presume there are other convenience artifacts with similar issues. > > > > > > > > Thanks, > > > > PJ > > > > > > > > On Fri, 27 Jun 2025 at 22:24, Alex Porcelli <porce...@apache.org> wrote: > > > > > > > > > > Hello everyone, > > > > > > > > > > This email serves as a call for votes to release Apache KIE > > > > > (Incubating) v10.1.0-rc1. > > > > > > > > > > The Apache KIE community has reviewed and approved the release of > > > > > Apache KIE (Incubating) v10.1.0-rc1. We now kindly request IPMC > > > > > members to review and cast their votes on this release. > > > > > > > > > > Apache KIE(incubating) - The home of the most popular business > > > > > automation open-source technologies, including Drools, jBPM, > > > > > SonataFlow, Optaplanner, Kogito, and Tools. > > > > > > > > > > KIE community vote thread: > > > > > https://lists.apache.org/thread/1hy6nb6511lpxp9f3dkcj3gb8rsfbr13 > > > > > > > > > > Vote result thread: > > > > > https://lists.apache.org/thread/kdd433g2fvz5g78yw88ktmh0gtm9ywgq > > > > > > > > > > You can access the release candidate artifacts here: > > > > > https://dist.apache.org/repos/dist/dev/incubator/kie/10.1.0-rc1/ > > > > > > > > > > Notes: > > > > > - There is only one source release: > > > > > https://dist.apache.org/repos/dist/dev/incubator/kie/10.1.0-rc1/apache-kie-10.1.0-incubating-sources.zip > > > > > - All other artifacts are convenient binaries. > > > > > > > > > > The artifacts are signed with PGP key corresponding to > > > > > [priv...@kie.apache.org], found in the KEYS file: > > > > > https://downloads.apache.org/incubator/kie/KEYS > > > > > > > > > > The vote will be open for at least 72 hours until the necessary number > > > > > of votes is reached. > > > > > > > > > > Please vote accordingly: > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > To learn more about KIE, please see https://kie.apache.org/ > > > > > > > > > > Checklist for reference: > > > > > > > > > > [ ] Download KIE artifacts are valid. > > > > > [ ] Checksums and PGP signatures are valid. > > > > > [ ] Source code distributions have correct names matching the current > > > > > release. > > > > > [ ] LICENSE and NOTICE files are correct. > > > > > [ ] All files have license headers if necessary. > > > > > [ ] No compiled archives bundled in source archive. > > > > > [ ] Can compile from source. > > > > > > > > > > For updated information on how to verify the release, please refer to: > > > > > https://kie.apache.org/docs/community/verify > > > > > > > > > > For updated information on how to build from source zip, please refer > > > > > to: > > > > > https://kie.apache.org/docs/community/build-10.1 > > > > > > > > > > - > > > > > Alex > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
