+0 (binding) I checked: * in the source distribution ** incubating is in the version/name ** signature and checksum are good ** DISCLAIMER is present ** LICENSE and NOTICE looks good ** No binary file found ** Some files don't have header in the console: *** public/css/console1412.css *** src/components/Page/Page.tsx *** src/components/Page/PageContent.tsx *** src/components/Page/PageHeader.tsx *** src/components/Page/index.ts *** test/README.md *** test/sample/configurationManagement.spec.js *** test/uploadfiles/uploadfiles.md ** The files in SQLParser are generated by antlr so it's ok (it would be great if the generated files include ASF header though) * in the binary distribution ** incubating is in the version/name ** DISCLAIMER is present ** in namingserver, LICENSE and NOTICE are present but: *** NOTICE should contain Jackson NOTICE. The LICENSE lists a lot of artifacts not present in the binary distribution (for instance, *** the LICENSE doesn't look correct: it mentions artifacts not actually present in namingserver (for instance Hikari, PostgreSQL JDBC, etc) ** in server, LICENSE and NOTICE are present but: *** the LICENSE doesn't look correct: it mentions artifacts not actually present in server (for instance jjwt-api, etc)
I'm voting 0 to not block your release and allow you to fix it in the next release, but as you are using DISCLAIMER (not DISCLAIMER-WIP), I was close to vote -1 :) Can you please fix this for the next release: 1. Add the ASF header where it's missing 2. Fix the LICENSE/NOTICE in binary distribution (both seata-namingserver and seata-server) ? Thanks ! Regards JB On Thu, May 29, 2025 at 8:08 AM jsbxyyx <jsbx...@apache.org> wrote: > > Hello everyone, > > This is a call for vote to release Apache Seata(incubating) v2.4.0-RC7 > > The Apache Seata community has voted and approved the release of Apache > Seata(incubating) v2.4.0-RC7. We now kindly request the IPMC members > review and vote for this release. > > > The vote thread: > https://lists.apache.org/thread/k3fdl5k35smtkh8hd27y5742nkcrk4fy > > Vote Result: > https://lists.apache.org/thread/nwpzjhzxm0x3jnp6k5c4sxkhf77zyopx > > The release candidates: > https://dist.apache.org/repos/dist/dev/incubator/seata/2.4.0-RC7/ > > The staging repo: > https://repository.apache.org/content/repositories/orgapacheseata-1263 > > Git tag for the release: > https://github.com/apache/incubator-seata/releases/tag/v2.4.0 > > Hash for the release tag: > > 5483453c03f49a67988d999aca895347a264b28c > > Release Notes: > https://github.com/apache/incubator-seata/releases/tag/v2.4.0 > > The artifacts have been signed with Key [ 63E269707E8BF0FB ], corresponding > to > [ jsbx...@apache.org ] > which can be found in the keys file: > https://downloads.apache.org/incubator/seata/KEYS > > Build Environment: JDK 8+, Apache Maven 3.6.0+. > ./mvnw clean package -DskipTests=true > > CI Test Workflow: > > https://github.com/apache/incubator-seata/actions/runs/15158145511/job/42675388776 > > https://github.com/apache/incubator-seata/actions/runs/15158145490/job/42620799602 > > https://github.com/apache/incubator-seata/actions/runs/15158145483/job/42675383527 > > The vote will be open for at least 72 hours. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Checklist for reference: > > [ ] Download links are valid. > [ ] Checksums and signatures. > [ ] LICENSE/NOTICE files exist > [ ] No unexpected binary files > [ ] All source files have ASF headers > [ ] Can compile from source > > To learn more about Apache Seata , please see https://seata.apache.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
