Hi Justin About picocli, it's actually listed with ALv2 (https://github.com/apache/polaris/blob/apache-polaris-0.10.0-beta-incubating-rc2/quarkus/admin/distribution/LICENSE#L691).
The NOTICE contains the Picocli NOTICE, mentioning: | This project includes one or more documentation files from OpenJDK, licensed under GPL v2 with Classpath Exception. | | These files are included in the source distributions, not in the binary distributions of this project. We use binary distribution of picocli (not source distribution): it's the jar we bundle in Polaris admin distribution. So, it's OK for me. I propose to remove the Picocli NOTICE as it does not really apply in Polaris case. Regards JB On Sat, May 10, 2025 at 12:19 PM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > > Hi Justin > > I'm confused about some points: > > 1. about Iceberg and Nessie NOTICE, during the 0.9.0 vote, you asked > to remove it explicitly. Are you now asking to add it (as I did > initially) ? And Iceberg NOTICE is not required as it's an ASF > project. > 2. Is really ASF header a blocker ? I see the same on a lot of other > ASF projects and podlings. For instance > https://github.com/apache/gravitino/blob/main/gradle/wrapper/gradle-wrapper.properties. > I agree to fix that for the next release, and it was already like this > in previous Polaris release. > 3. About helm chart logging_storage_test.yaml, it's a mistake, the ASF > header should be used here. > 4. About the picocli dependency in the admin distribution, it's > actually under the ASF license (not GPL): > https://github.com/remkop/picocli/blob/main/LICENSE, I will fix that. > > Regards > JB > > On Sat, May 10, 2025 at 9:20 AM Justin Mclean <jus...@classsoftware.com> > wrote: > > > > Hi, > > > > -1 (binding) form me. > > > > I checked: > > - incubating in name > > - signatures and hashes are file > > - LICENSE is missing one file, but give the header issue, other 3rd party > > files may not be listed. > > - NOTICE is misisng information from Iceberg NOTICE file and Project Nessie > > NOTICE file. > > - Non-ASF 3rd party files incorrectly have ASF headers > > [1][2][3][4][5][6][7][8] and the files from Project Nessie. > > - No unexpected binary files > > - I did not compile from sourse > > > > This 3rd party file [9] is not mentioned in the LICENSE file. > > > > This file is concerning [10] as it looks to be stating that the source > > release contains GPL-licensed source code. Do we know what is going on here? > > > > Kind Regards, > > Justin > > > > 1. gradle/wrapper/gradle-wrapper.properties > > 2. server-templates/*.mustache > > 3. site/layouts/community/list.html > > 4. site/layouts/docs/baseof.html > > 5. site/layouts/partials/community_links.html > > 6. site/layouts/partials/head.html > > 7. site/layouts/partials/navbar.html > > 8. site/layouts/shortcodes/redoc-polaris.html > > 9. ./helm/polaris/tests/logging_storage_test.yaml > > 10. ./quarkus/admin/distribution/NOTICE > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
