+1 (binding)

I checked:
- signature and checksum are good for the source distribution
- the LICENSE in the source distribution is OK. Nit: I think it would
be great to mention code coming from other projects (MemorySize is
coming from Flink, DynMethods, etc are coming from Parquet). It's OK
because it's ASF projects here, just to clarify it :)
- NOTICE is OK. Nit: the NOTICE can be lighter: no need to mention the
ASF projects here (Iceberg, Paimon, Flink)
- No binary file found in the source distribution
- ASF header is present in all expected files
- signature and checksum are good in the binary distributions (hadoop2
and hadoop3)
- Nit: no need to mention all ASF projects in the binary distribution
NOTICE file
- binary distribution NOTICE should content the NOTICE from ALv2
project (non ASF), for instance Jackson, AWS SDK, Netty, etc. That
would be great to double check that for next releases.

I was hesitant to vote +0, due to the question about binary
distribution NOTICE, I think we can fix that in the next release.

Regards
JB

On Wed, May 7, 2025 at 12:32 PM Yu Li <car...@gmail.com> wrote:
>
> +1 (binding)
>
> - Checked release file name and location: OK
> - Checked sum and signatures: OK
> - Checked DISCLAIMER file exists: OK
> - Checked LICENSE and NOTICE files: OK
> - Checked no binary files in source package: OK
> - Checked compile from source: OK (JDK 8u181)
>
> Best Regards,
> Yu
>
>
> On Wed, 30 Apr 2025 at 17:47, Xinyu Zhou <yu...@apache.org> wrote:
>
> > +1 binding.
> >
> > I checked:
> >
> > [-] Download links are valid.
> > [-] Checksums and signatures.
> > [-] LICENSE/NOTICE files exist
> >
> > On Mon, Apr 28, 2025 at 8:56 AM Congxian Qiu <qcx978132...@gmail.com>
> > wrote:
> >
> > > carry my no binding +1 from dev ml vote thread.
> > >
> > > Best,
> > > Congxian
> > >
> > >
> > > tao wang <wtrunw...@gmail.com> 于2025年4月27日周日 17:39写道:
> > >
> > > > Hello Incubator PMC,
> > > >
> > > > The Apache Amoro community has voted and approved the release of Apache
> > > > Amoro(incubating) 0.8.0-incubating rc3.
> > > > We now kindly request the IPMC members review and vote for this
> > release.
> > > >
> > > > Apache Amoro (incubating) is a Lakehouse management system built on
> > open
> > > > data lake formats.
> > > >
> > > > Amoro community vote thread:
> > > > https://lists.apache.org/thread/22rrpzwtzkby8vnhfvcwzmpfxxz8qhns
> > > >
> > > > Vote result thread:
> > > > https://lists.apache.org/thread/gokj30ldgh3p5866tw40h41mhdw90whs
> > > >
> > > > The official Apache source release to be deployed to dist.apache.org:
> > > >
> > > >
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/amoro/0.8.0-incubating-RC3/
> > > >
> > > > This source release has been signed with a PGP available here (Apache
> > ID:
> > > > taowang):
> > > > https://downloads.apache.org/incubator/amoro/KEYS
> > > >
> > > > All artifacts to be deployed to the Maven Central Repository:
> > > > https://repository.apache.org/content/repositories/orgapacheamoro-1072
> > > >
> > > > Git branch for the release:
> > > > https://github.com/apache/amoro/tree/v0.8.0-rc3
> > > >
> > > > Please download, verify, and test.
> > > >
> > > > The VOTE will pass after 3 binding approvals.
> > > >
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > To learn more about Apache Amoro, please see https://amoro.apache.org/
> > > >
> > > > Checklist for reference:
> > > >
> > > > [ ] Download links are valid.
> > > > [ ] Checksums and signatures.
> > > > [ ] LICENSE/NOTICE files exist
> > > > [ ] No unexpected binary files
> > > > [ ] All source files have ASF headers
> > > > [ ] Can compile from source
> > > >
> > >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to