Hello Justin, Thank you for your thorough review.
> - LICENSE is misisng info on [3][4]? I’m not sure to understand this point. I checked both file and they have a license information in their header. > - NOTICE contains information on MIT/BSD license code when it should not Does this mean I should remove all the notices related to MIT/BSD? For instance, I thought the following notice would be helpful as it shows where the relicensing discussion occurred. From my understanding a notice is some sort of observation, notification, or warning. This product includes protocol buffers definitions derived from OSMPBF. MIT License. Please visit the following URLs for the licensing information: - https://github.com/openstreetmap/OSM-binary/issues/18 - https://github.com/openstreetmap/OSM-binary/pull/35 The derived files are: - baremaps-core/src/main/proto/osmformat.proto - baremaps-core/src/main/proto/fileformat.proto To be honest, I’m also getting more and more confused about what the NOTICE file should and shouldn’t contain. As the intent is to remove the DISCLAIMER-WIP for this release, it would be great to schedule a peer programming session with someone who went through this process. > - How is this file is misisng a header [1] Thanks, I will fix it. > - How is this file licensed? [2] Good catch. I will probably create a synthetic file to replace it. > - No unexpected binary files > - I did not compile > > For licenses like BSD and MIT the full text of teh license need to be > included. It also unclear what project some 3rd party files belong to. Should the complete licences be placed in a specific file or directory? The NOTICE file currently contains the information to navigate what project some 3rd party files belong to. For instance, the following notice allows you to navigate to the 3rd party project and the related code. This product includes test data copied from PMTiles. BSD-3-Clause license. Please visit the following URL for the full text of the PMTiles license: https://github.com/protomaps/PMTiles The copied files are located in: - baremaps-core/src/test/resources/pmtiles/ Thanks for your help, Bertil > Kind Regards, > Justin > > 1. ./scripts/generate-flatgeobuf.sh > 2. ./baremaps-dem/src/test/resources/fuji.png > 3. > ./baremaps-postgres/src/main/java/org/apache/baremaps/postgres/copy/CopyWriter.java > 4. ./baremaps-flatgeobuf/src/main/fbs/header.fbs > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
