Thanks for review.
The LICENSE/NOTICE issue is fixed here[1], please check if it's
right now.
For docker image release, we're using github action here[2], but
there are no docs for this, I will add it here[3].
[1]. https://github.com/apache/horaedb/pull/1587
[2].
https://github.com/apache/horaedb/blob/main/.github/workflows/publish-image.yml
[3]. https://github.com/apache/horaedb/wiki/ASF-review-guide
On Mon, Nov 04, 2024 at 11:41:26 PM +0800, PJ Fanning wrote:
-1 (binding) fanningpj (IPMC)
The NOTICE is incorrect as far as I am concerned.
https://github.com/apache/horaedb/blob/main/NOTICE
The MIT LIcense stuff should be in the LICENSE not in the
NOTICE.
I also think most of the Apache License stuff in the NOTICE
should be
in the LICENSE instead.
My understanding is that when you borrow code from Apache
Licensed
projects, that you copy the LICENSE details from those projects
into
your LICENSE and the NOTICE details from those projects into
your
NOTICE. There is some scope to avoid duplicating text.
I would suggest that you look at other Apache projects to see
their
licenses and notices.
I would also like some guidance on your binary artifacts. None
have
been linked to this vote thread but you do appear to release
Docker
images, for example. It would be useful to allow these to be
validated
as part of the release process. Do you have a release guide for
these
binary artifacts so that IPMC members and other interested
parties can
review them?
On Mon, 4 Nov 2024 at 04:35, Zili Chen <ti...@apache.org> wrote:
+1 (binding)
+ Download links are valid.
+ Checksums and signatures.
+ LICENSE/NOTICE files exist
+ No unexpected binary files
+ Can compile from source
Best,
tison.
On 2024/10/30 14:46:07 Jiacai Liu wrote:
>
> Thanks for reviewing, I've updated the documentation to
> include
> solutions for encountered issues.
> - https://github.com/apache/horaedb-docs/pull/151
>
> On Wed, Oct 30, 2024 at 07:18:14 PM +0800, ShaoFeng Shi
> wrote:
>
> > Hello, here is my vote:
> >
> > +1 (binding) (IPMC, id: shaofengshi)
> >
> > I checked the followings:
> > [*] Download links are valid.
> > [*] Checksums and signatures.
> > [*] LICENSE/NOTICE files exist
> > [*] No unexpected binary files
> > [*] Can compile from source
> >
> > BTW, on my MacBook I need run "ulimit -f unlimited" first,
> > otherwise the
> > compilation will fail with "error: could not compile
> > `regex-syntax` (lib)"
> > message. I guess the compilation may creates some big file
> > larger than
> > Mac's default file size.
> >
> >
> > Best regards,
> >
> > Shaofeng Shi 史少锋
> > Apache Kylin PMC member,
> > Apache Incubator PMC member,
> > Email: shaofeng...@apache.org
> >
> >
> >
> >
> >
> >
> > Jiacai Liu <d...@liujiacai.net> 于2024年10月30日周三 16:15写
> > 道：
> >
> >> Hello everyone,
> >>
> >> This is a call for the vote to release Apache
> >> HoraeDB(incubating)
> >> v2.1.0-rc.2.
> >>
> >> The Apache HoraeDB(incubating) community has voted and
> >> approved
> >> the release of Apache
> >> HoraeDB(incubating) v2.1.0-rc.2. We now kindly request the
> >> IPMC
> >> members
> >> review and vote for this release.
> >>
> >> HoraeDB community vote thread:
> >> https://lists.apache.org/thread/7ckkrgvpjqyxf9wcpxy1q32k7s7rhsol
> >>
> >> Vote result thread:
> >> https://lists.apache.org/thread/8q69rl81f8hmo5790qpx4wv2w9kp8vkx
> >>
> >> The release candidate:
> >>
> >>
https://dist.apache.org/repos/dist/dev/incubator/horaedb/horaedb/v2.1.0-rc.2/
> >>
> >> This release has been signed with a PGP available here:
> >> https://downloads.apache.org/incubator/horaedb/KEYS
> >>
> >> Git tag for the release:
> >> https://github.com/apache/horaedb/releases/tag/v2.1.0-rc.2
> >>
> >> Git commit for the release:
> >>
> >>
https://github.com/apache/horaedb/commit/09dace755f50cc92dc670f6f03cf4d60d6fed753
> >>
> >> The vote will be open for at least 72 hours or until the
> >> necessary
> >> number
> >> of votes are reached.
> >>
> >> Please vote accordingly:
> >> [ ] +1 approve
> >> [ ] +0 no opinion
> >> [ ] -1 disapprove with the reason
> >>
> >> Checklist for reference:
> >> [ ] Download links are valid.
> >> [ ] Checksums and signatures.
> >> [ ] LICENSE/NOTICE files exist
> >> [ ] No unexpected binary files
> >> [ ] All source files have ASF headers
> >> [ ] Can compile from source
> >>
> >> To compile from the source, please refer to:
> >> https://horaedb.apache.org/docs/dev/compile_run/
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail:
> >> general-unsubscr...@incubator.apache.org
> >> For additional commands, e-mail:
> >> general-h...@incubator.apache.org
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> general-unsubscr...@incubator.apache.org
> For additional commands, e-mail:
> general-h...@incubator.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail:
general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail:
general-h...@incubator.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
