Hi Fanning, Thanks for the help.
I updated DISCLAIMER-WIP and placed the licenses there. https://github.com/apache/incubator-resilientdb/blob/master/DISCLAIMER-WIP On Sun, May 5, 2024 at 2:46 PM PJ Fanning <fannin...@apache.org> wrote: > That is not a valid DISCLAIMER-WIP. > > Please read https://incubator.apache.org/policy/incubation.html > > It has the correct text for a DISCLAIMER-WIP and you need to spell out what > your issues are. For instance, it appears that you still have work to do to > get the license corrected. You could list that in the DISCLAIMER-WIP. > > Apache Liminal has a DISCLAIMER-WIP. > > https://github.com/apache/incubator-liminal/blob/master/DISCLAIMER-WIP > > On Sun, 5 May 2024 at 22:35, Junchao Chen <jucc...@ucdavis.edu.invalid> > wrote: > > > hi John, > > > > Thanks for the suggestions and sorry for the confusion. > > We don't support MAC in the current state, the install file > INSTALL_MAC.sh > > <http://resilientdb-v1.10.0-incubatinginstall_mac.sh/> is outdated and I > > have removed it from our source code. > > > > I have renamed DISCLAIMER to DISCLAIMER-WIP > > < > > > https://github.com/apache/incubator-resilientdb/blob/master/DISCLAIMER-WIP > > > > > and > > also fixed the typo. > > Also renamed the release source prefix to > "apache-resilientdb-incubating": > > > > > https://dist.apache.org/repos/dist/dev/incubator/resilientdb/resilientdb/v1.10.0-rc1 > > > > > > For the LICENSE, > > RocksDB and zstd have been removed from our project. > > So we don't rely on any GPL code. > > I also added the version for each dependency. > > > > > > > > Any other suggestions? > > > > Thanks, > > Junchao > > > > > > > > On Sun, May 5, 2024 at 4:44 AM John D. Ament <johndam...@apache.org> > > wrote: > > > > > On Sun, May 5, 2024 at 12:12 AM John D. Ament <johndam...@apache.org> > > > wrote: > > > > > > > > > > > > > > > On Sat, May 4, 2024 at 8:50 PM Junchao Chen > > <jucc...@ucdavis.edu.invalid > > > > > > > > wrote: > > > > > > > >> hi Justin, > > > >> > > > >> I have removed all the related code from the source files, and there > > are > > > >> no > > > >> GPL dependencies there. > > > >> Those dependencies are an optional setting in our project, it is not > > > >> necessary. > > > >> > > > > > > > > Just to put it out there - I think the license listing for RocksDB is > > > > wrong. It's a dual licensed piece of software (GPLv2 + Apache > License > > > > V2). Similar for zstd, it's a dual license BSD-3 and GPLv2. So I > > > suspect > > > > the real issue is that you mislabeled it as GPLv2 but you actually > > wanted > > > > to label them under the permissive license we can use. > > > > > > > > And keep in mind, your source license file should represent the > > contents > > > > of your source release. If you bring in dependencies when building, > > you > > > > should reference those separately, likely under a binary release. > > > > > > > > Just wondering, but who are your mentors? What was their feedback on > > the > > > > release? They should be able to help you sort this out. > > > > > > > > > > Sorry, I think I understand what's happening now. You had a mentor > vote > > -1 > > > at [1] and were looking for other IPMC members to review it since there > > was > > > no additional feedback on the release. It's a little confusing that > you > > > forwarded your dev@ vote thread to general@ so there was likely some > > > context missing on what the ask is. Apologies for any confusion from > me. > > > > > > Looking at your release, I think you just appended > > > "resilientdb-v1.10.0-incubating" to all of your folders and root files. > > > This isn't required, we just ask that the source release be named with > > > "-incubating" somewhere in it. It would be better if the source > release > > > said "apache-resilientdb-incubating" or similar though. The result of > > > appending the name though is your DISCLAIMER goes missing. The one > > > distributed talks about Apache Answer, are you in fact using Answer? If > > not > > > maybe there was a copy/paste issue. You may want to switch to > > > DISCLAIMER-WIP since this is your first release. > > > > > > I attempted to run resilientdb-v1.10.0-incubatingINSTALL_MAC.sh on my > > > machine, it failed. > > > > > > [1]: https://lists.apache.org/thread/d9krfb42262xbbdb75jnz2tsbs367mst > > > > > > > > > > > > > > > > > >> > > > >> Thanks, > > > >> junchao > > > >> > > > >> On Sat, May 4, 2024 at 5:36 PM Justin Mclean < > > jus...@classsoftware.com> > > > >> wrote: > > > >> > > > >> > HI, > > > >> > > > > >> > > Thanks for letting me know. > > > >> > > I have removed those dependencies. > > > >> > > > > >> > What goes in the license file is any 3rd party licenses that are > > > >> included > > > >> > in the source release, not those that are dependencies. But unless > > it > > > is > > > >> > optional, you also can’t have any GPL dependencies. > > > >> > > > > >> > Kind Regards, > > > >> > Justin > > > >> > > > --------------------------------------------------------------------- > > > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > >> > For additional commands, e-mail: > general-h...@incubator.apache.org > > > >> > > > > >> > > > > >> > > > > > > > > > >
